Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an easy to find means (e.g. css variable at the top) for removing icons from main menubar for photon version #267

Closed
redmasq opened this issue Nov 8, 2021 · 4 comments
Labels
Issue::Code Code quality and project structure, etc Issue::Enhancement New feature or request

Comments

@redmasq
Copy link

redmasq commented Nov 8, 2021

Is your feature request related to a problem?
The 89 and previous version of Firefox under windows did not have the icon preceding the menu on the main bar.

The solution I'd like
Since some people may actually like the icon (I hate it, but I can see the appeal to some), a CSS property with a 1 or 0 might could be used to turn off the padding using multiplication. I am wondering if a negative margin can be used to hide the icon without removing it. Otherwise, notation as comment of the line number start for the rule to comment will have to suffice.

Alternatives I've considered
At the very least, add comment at the top that contains the line numbers to edit. Also, a prebuilt package with that variant would suffice as well, but yet one more thing to maintain.

Additional context
Thanks for making this in the first place. Saved me a ton of trouble.

@redmasq redmasq added the Issue::Enhancement New feature or request label Nov 8, 2021
@redmasq
Copy link
Author

redmasq commented Nov 8, 2021

To get the end result for which I was hoping, I did the following to userChrome.css:

  • Commented started at 3574 to 3595.
  • Removed the additional padding on 2695
  • Changed the padding on 2700 to 3px from the 19px that was there.

@black7375 black7375 added the Issue::Code Code quality and project structure, etc label Nov 9, 2021
@black7375
Copy link
Owner

black7375 commented Nov 9, 2021

Although the current line of code is different, it does exist on the wiki.
https://github.com/black7375/Firefox-UI-Fix/wiki/Tips#remove-menubar-icon


It's too time consuming to go through the documentation to update that line of code with every update.

So, After v4.5 was released, I was thinking of making them all with the same CSS settings[master, photon-style, proton-style] in the next update.

Firefox has a syntax that can determine whether or not CSS is applied based on the existence of a setting in about:setting.

@supports -moz-bool-pref("ABOUT.CONFIG.SETTTING.NAME") {
}

@redmasq
Copy link
Author

redmasq commented Nov 9, 2021

I wasn't aware of that particular feature, but I don't do a lot of work with the userChrome. It sounds like a plan at least. I'll take a look at the wiki in the morning. Thank you

@black7375
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue::Code Code quality and project structure, etc Issue::Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants