Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality of the project #234

Closed
akisblack opened this issue Sep 29, 2021 · 4 comments
Closed

Improve code quality of the project #234

akisblack opened this issue Sep 29, 2021 · 4 comments
Labels
Issue::Code Code quality and project structure, etc Issue::Enhancement New feature or request Priority::High Solve and focus on it first

Comments

@akisblack
Copy link

Is your feature request related to a problem?
Yes, the code quality of this project is kinda bad and not documented.

The solution I'd like
Using SCSS and compiling it after would be ideal since it could be split up into multiple files, use nesting and other useful features SCSS provides.

Alternatives I've considered
None really. Unless someone goes out of their way to document all this single file mess I don't think this codebase will hold up for much longer.

Additional context
SCSS site

@akisblack akisblack added the Issue::Enhancement New feature or request label Sep 29, 2021
@black7375
Copy link
Owner

I was also considering it.

  1. Currently, I only keep it as a css file for people's customization. (SCSS requires compilation)
  2. It reduces mistakes in the manual installation process and does not split files due to performance problems of @import.
  3. JS will probably be introduced in the future, and if it can be controlled as an option in the settings window, we will use the SCSS method.

Thank you for your interest in the project.

@akisblack
Copy link
Author

Yeah, your third point seems really exciting. Thanks for the response

@black7375 black7375 added the Issue::Code Code quality and project structure, etc label Oct 9, 2021
@black7375 black7375 mentioned this issue Nov 19, 2021
31 tasks
@black7375 black7375 added the Priority::High Solve and focus on it first label Dec 15, 2021
@black7375
Copy link
Owner

black7375 commented Dec 15, 2021

It's a little late, but I started the migration.
https://github.com/black7375/Firefox-UI-Fix/tree/scss


It may take a while because I've been a little busy lately.

@black7375 black7375 mentioned this issue Mar 27, 2022
14 tasks
@black7375
Copy link
Owner

Built with SASS from version v5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue::Code Code quality and project structure, etc Issue::Enhancement New feature or request Priority::High Solve and focus on it first
Projects
None yet
Development

No branches or pull requests

2 participants