Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Error when targeting macOS/tvOS using Xcode 10 #380

Closed
8 of 9 tasks
JonathanDowning opened this issue Jun 19, 2018 · 7 comments
Closed
8 of 9 tasks

Compile Error when targeting macOS/tvOS using Xcode 10 #380

JonathanDowning opened this issue Jun 19, 2018 · 7 comments

Comments

@JonathanDowning
Copy link
Contributor

JonathanDowning commented Jun 19, 2018

Platform

  • iOS
  • macOS
  • tvOS

In app purchase type

  • Consumable
  • Non-consumable
  • Auto-Renewable Subscription
  • Non-Renewing Subscription

Environment

  • Sandbox
  • Production

Version

0.13.2

Related issues

N/A

Report

Issue summary

SwiftyStoreKit will not compile for macOS/tvOS using Xcode 10, the following error is emitted:

Cannot override 'paymentQueue' which has been marked unavailable
at this location:

https://github.com/bizz84/SwiftyStoreKit/blob/master/SwiftyStoreKit/PaymentQueueController.swift#L242

This is because

- (BOOL)paymentQueue:(SKPaymentQueue *)queue shouldAddStorePayment:(SKPayment *)payment forProduct:(SKProduct *)product NS_SWIFT_NAME(paymentQueue(_:shouldAddStorePayment:for:))

is marked as NS_AVAILABLE_IOS(11_0);

What did you expect to happen

SwiftyStoreKit should compile on macOS/tvOS.

What happened instead

Compilation fails due to the aforementioned error.

@shaynem
Copy link

shaynem commented Jun 28, 2018

+1 just an into this issue myself

@KodaKoder
Copy link

+1 is impossible to compile with xcode10/mac

@Bloophub
Copy link

Bloophub commented Jul 5, 2018

+1

@paulocoutinhox
Copy link

Please, merge:
#381

@bizz84
Copy link
Owner

bizz84 commented Jul 16, 2018

This is now fixed and available on pod version 0.13.3.

Apologies for the very late reply everyone.

@bizz84 bizz84 closed this as completed Jul 16, 2018
@paulocoutinhox
Copy link

Thanks.

@easiwriter
Copy link

Still doesn't compile when installed using cocoapods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants