Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Reframing #693

Open
rslawson opened this issue Dec 4, 2024 · 0 comments
Open

Test Reframing #693

rslawson opened this issue Dec 4, 2024 · 0 comments

Comments

@rslawson
Copy link
Collaborator

rslawson commented Dec 4, 2024

So currently, reframing goes completely unused in any of our HITL tests. I attempted to enable it in my rs/swCcTopologiesTest-rfen branch, but for various reasons I stopped work on that for the time being. Furthermore, whether reframing is enabled is configured on the Clash side of things and passed through to the software by way of an MMIO register, but this should probably be done by some other mechanism.

As for why I stopped work on reframing testing, there's a couple reasons.

  1. There's not a good way currently to ensure that reframing begins at the same time across all nodes in the test. Maybe there's a case to be made for using a constant offset from the start of the test, but this would only work within the context of the topology tests where we can make assumptions about an upper bound for stabilisation.
  2. For some reason, the Rust code doesn't actually seem to affect the clock offsets? As far as I can tell the reframing enable is getting passed through to the Rust code, but it's never actually doing anything with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant