From d560a640adc66fe465b0bafeb6b3b69f75c3f059 Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Thu, 13 Feb 2014 21:09:11 +0100 Subject: [PATCH 1/3] Fix leak in BITKeychainUtils --- Classes/BITKeychainUtils.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Classes/BITKeychainUtils.m b/Classes/BITKeychainUtils.m index 55574f64..6726cdea 100644 --- a/Classes/BITKeychainUtils.m +++ b/Classes/BITKeychainUtils.m @@ -200,7 +200,7 @@ + (BOOL) storeUsername: (NSString *) username andPassword: (NSString *) password NSDictionary *query = [[NSDictionary alloc] initWithObjects: objects forKeys: keys]; - status = SecItemUpdate((__bridge_retained CFDictionaryRef) query, (__bridge_retained CFDictionaryRef) [NSDictionary dictionaryWithObject: [password dataUsingEncoding: NSUTF8StringEncoding] forKey: (__bridge_transfer NSString *) kSecValueData]); + status = SecItemUpdate((__bridge CFDictionaryRef) query, (__bridge CFDictionaryRef) [NSDictionary dictionaryWithObject: [password dataUsingEncoding: NSUTF8StringEncoding] forKey: (__bridge_transfer NSString *) kSecValueData]); } } else @@ -226,7 +226,7 @@ + (BOOL) storeUsername: (NSString *) username andPassword: (NSString *) password NSDictionary *query = [[NSDictionary alloc] initWithObjects: objects forKeys: keys]; - status = SecItemAdd((__bridge_retained CFDictionaryRef) query, NULL); + status = SecItemAdd((__bridge CFDictionaryRef) query, NULL); } if (error != nil && status != noErr) From 3b9f38fd1606ca7326a565f780e57c31aa108d7b Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Tue, 18 Feb 2014 16:03:11 +0100 Subject: [PATCH 2/3] Fix a crash if no selector could be found --- Classes/BITCrashReportTextFormatter.m | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Classes/BITCrashReportTextFormatter.m b/Classes/BITCrashReportTextFormatter.m index 1acc07c9..5c6b576c 100644 --- a/Classes/BITCrashReportTextFormatter.m +++ b/Classes/BITCrashReportTextFormatter.m @@ -599,7 +599,9 @@ + (NSString *)selectorForRegisterWithName:(NSString *)regName ofThread:(BITPLCra // get the SEL const char *foundSelector = findSEL([imageForRegAddress.imageName UTF8String], imageForRegAddress.imageUUID, regAddress - (uint64_t)imageForRegAddress.imageBaseAddress); - return [NSString stringWithUTF8String:foundSelector]; + if (foundSelector != NULL) { + return [NSString stringWithUTF8String:foundSelector]; + } } return nil; From ac0790646b881dee9cb51501089591a0f1eaa327 Mon Sep 17 00:00:00 2001 From: Andreas Linde Date: Tue, 18 Feb 2014 16:09:28 +0100 Subject: [PATCH 3/3] 3.5.4 release and documentation updates --- HockeySDK.podspec | 6 +++--- README.md | 14 +++++++------- Support/buildnumber.xcconfig | 4 ++-- docs/Changelog-template.md | 6 ++++++ docs/Guide-Installation-Setup-Advanced-template.md | 6 +++--- docs/Guide-Installation-Setup-template.md | 6 +++--- 6 files changed, 24 insertions(+), 18 deletions(-) diff --git a/HockeySDK.podspec b/HockeySDK.podspec index 8080cb46..2d13ab52 100644 --- a/HockeySDK.podspec +++ b/HockeySDK.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'HockeySDK' - s.version = '3.5.3' + s.version = '3.5.4' s.summary = 'Collect live crash reports, get feedback from your users, distribute your betas, and analyze your test coverage with HockeyApp.' s.description = <<-DESC @@ -12,7 +12,7 @@ Pod::Spec.new do |s| DESC s.homepage = 'http://hockeyapp.net/' - s.documentation_url = 'http://hockeyapp.net/help/sdk/ios/3.5.3/' + s.documentation_url = 'http://hockeyapp.net/help/sdk/ios/3.5.4/' s.license = 'MIT' s.author = { 'Andreas Linde' => 'mail@andreaslinde.de', 'Thomas Dohmke' => "thomas@dohmke.de" } @@ -24,7 +24,7 @@ Pod::Spec.new do |s| s.frameworks = 'CoreText', 'QuartzCore', 'SystemConfiguration', 'CoreGraphics', 'UIKit', 'Security' s.ios.vendored_frameworks = 'Vendor/CrashReporter.framework' - s.xcconfig = {'GCC_PREPROCESSOR_DEFINITIONS' => %{$(inherited) BITHOCKEY_VERSION="@\\"#{s.version}\\"" BITHOCKEY_BUILD="@\\"26\\""} } + s.xcconfig = {'GCC_PREPROCESSOR_DEFINITIONS' => %{$(inherited) BITHOCKEY_VERSION="@\\"#{s.version}\\"" BITHOCKEY_BUILD="@\\"27\\""} } s.resource_bundle = { 'HockeySDKResources' => ['Resources/*.png', 'Resources/*.lproj'] } s.preserve_paths = 'Resources', 'Support' diff --git a/README.md b/README.md index b1d764e6..1fc4f8f5 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ -## Version 3.5.3 +## Version 3.5.4 -- [Changelog](http://www.hockeyapp.net/help/sdk/ios/3.5.3/docs/docs/Changelog.html) +- [Changelog](http://www.hockeyapp.net/help/sdk/ios/3.5.4/docs/docs/Changelog.html) ## Introduction @@ -31,10 +31,10 @@ The main SDK class is `BITHockeyManager`. It initializes all modules and provide ## Installation & Setup -- [Installation & Setup](http://www.hockeyapp.net/help/sdk/ios/3.5.3/docs/docs/Guide-Installation-Setup.html) (Recommended) -- [Installation & Setup Advanced](http://www.hockeyapp.net/help/sdk/ios/3.5.3/docs/docs/Guide-Installation-Setup-Advanced.html) (Using Git submodule and Xcode sub-project) -- [Identify and authenticate users of Ad-Hoc or Enterprise builds](http://www.hockeyapp.net/help/sdk/ios/3.5.3/docs/docs/HowTo-Authenticating-Users-on-iOS.html) -- [Migration from previous SDK Versions](http://www.hockeyapp.net/help/sdk/ios/3.5.3/docs/docs/Guide-Migration-Kits.html) +- [Installation & Setup](http://www.hockeyapp.net/help/sdk/ios/3.5.4/docs/docs/Guide-Installation-Setup.html) (Recommended) +- [Installation & Setup Advanced](http://www.hockeyapp.net/help/sdk/ios/3.5.4/docs/docs/Guide-Installation-Setup-Advanced.html) (Using Git submodule and Xcode sub-project) +- [Identify and authenticate users of Ad-Hoc or Enterprise builds](http://www.hockeyapp.net/help/sdk/ios/3.5.4/docs/docs/HowTo-Authenticating-Users-on-iOS.html) +- [Migration from previous SDK Versions](http://www.hockeyapp.net/help/sdk/ios/3.5.4/docs/docs/Guide-Migration-Kits.html) - [Mac Desktop Uploader](http://support.hockeyapp.net/kb/how-tos/how-to-upload-to-hockeyapp-on-a-mac) @@ -48,4 +48,4 @@ This documentation provides integrated help in Xcode for all public APIs and a s 3. Copy the content into ~`/Library/Developer/Shared/Documentation/DocSets` -The documentation is also available via the following URL: [http://hockeyapp.net/help/sdk/ios/3.5.3/](http://hockeyapp.net/help/sdk/ios/3.5.3/) +The documentation is also available via the following URL: [http://hockeyapp.net/help/sdk/ios/3.5.4/](http://hockeyapp.net/help/sdk/ios/3.5.4/) diff --git a/Support/buildnumber.xcconfig b/Support/buildnumber.xcconfig index 8c2c2802..39e6f651 100644 --- a/Support/buildnumber.xcconfig +++ b/Support/buildnumber.xcconfig @@ -1,7 +1,7 @@ #include "HockeySDK.xcconfig" -BUILD_NUMBER = 26 -VERSION_STRING = 3.5.3 +BUILD_NUMBER = 27 +VERSION_STRING = 3.5.4 GCC_PREPROCESSOR_DEFINITIONS = $(inherited) BITHOCKEY_VERSION="@\""$(VERSION_STRING)"\"" BITHOCKEY_BUILD="@\""$(BUILD_NUMBER)"\"" BIT_ARM_ARCHS = armv7 armv7s arm64 BIT_SIM_ARCHS = x86_64 i386 diff --git a/docs/Changelog-template.md b/docs/Changelog-template.md index 8c8c76b4..5b804fb1 100644 --- a/docs/Changelog-template.md +++ b/docs/Changelog-template.md @@ -1,3 +1,9 @@ +## Version 3.5.4 + +- [BUGFIX] Fix a possible crash before sending the crash report when the selector could not be found +- [BUGFIX] Fix a memory leak in keychain handling +

+ ## Version 3.5.3 - [NEW] Crash Reports now provide the selector name e.g. for crashes in `objc_MsgSend` diff --git a/docs/Guide-Installation-Setup-Advanced-template.md b/docs/Guide-Installation-Setup-Advanced-template.md index 396638a7..5b8e1ee2 100644 --- a/docs/Guide-Installation-Setup-Advanced-template.md +++ b/docs/Guide-Installation-Setup-Advanced-template.md @@ -1,6 +1,6 @@ -## Version 3.5.1 +## Version 3.5.4 -- [Changelog](http://www.hockeyapp.net/help/sdk/ios/3.5.1/docs/docs/Changelog.html) +- [Changelog](http://www.hockeyapp.net/help/sdk/ios/3.5.4/docs/docs/Changelog.html) ## Introduction @@ -116,7 +116,7 @@ This documentation provides integrated help in Xcode for all public APIs and a s 3. Copy the content into ~`/Library/Developer/Shared/Documentation/DocSets` -The documentation is also available via the following URL: [http://hockeyapp.net/help/sdk/ios/3.5.1/](http://hockeyapp.net/help/sdk/ios/3.5.1/) +The documentation is also available via the following URL: [http://hockeyapp.net/help/sdk/ios/3.5.4/](http://hockeyapp.net/help/sdk/ios/3.5.4/) ### Set up with xcconfig diff --git a/docs/Guide-Installation-Setup-template.md b/docs/Guide-Installation-Setup-template.md index b7ac0ed7..91a7a5e1 100644 --- a/docs/Guide-Installation-Setup-template.md +++ b/docs/Guide-Installation-Setup-template.md @@ -1,6 +1,6 @@ -## Version 3.5.1 +## Version 3.5.4 -- [Changelog](http://www.hockeyapp.net/help/sdk/ios/3.5.1/docs/docs/Changelog.html) +- [Changelog](http://www.hockeyapp.net/help/sdk/ios/3.5.4/docs/docs/Changelog.html) ## Introduction @@ -92,7 +92,7 @@ This documentation provides integrated help in Xcode for all public APIs and a s 1. Copy `de.bitstadium.HockeySDK-iOS-3.5.1.docset` into ~`/Library/Developer/Shared/Documentation/DocSets` -The documentation is also available via the following URL: [http://hockeyapp.net/help/sdk/ios/3.5.1/](http://hockeyapp.net/help/sdk/ios/3.5.1/) +The documentation is also available via the following URL: [http://hockeyapp.net/help/sdk/ios/3.5.4/](http://hockeyapp.net/help/sdk/ios/3.5.4/) ### Set up with xcconfig