Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: don't build separate wheels for different Python versions #1010

Closed
akx opened this issue Feb 1, 2024 · 3 comments
Closed

CI: don't build separate wheels for different Python versions #1010

akx opened this issue Feb 1, 2024 · 3 comments
Labels

Comments

@akx
Copy link
Contributor

akx commented Feb 1, 2024

We don't need to build Python wheels with both cp310 and cp311 tags; Python 3.11 (and 3.12) is fine with cp310 wheels. Since we don't actually use Python's extension ABI, that should be fine no matter what.

We just need to figure out a stable way to force always emitting a cp310 wheel. https://github.com/karellen/wheel-axle/ seems to do that but I'm a bit hesitant to add a whole new dep for that.

@younesbelkada
Copy link
Collaborator

Thanks @akx ! If I understand correctly this is only for python == 3.10 & 3.11 ? For older python versions we need to build separate wheels right?

@akx
Copy link
Contributor Author

akx commented Feb 2, 2024

No, a. cp38 wheel should work just as fine (though it needs a bit of experimentation).

@matthewdouglas
Copy link
Member

Closing this as we've been building one set of wheels tagged as just py3 for all Python versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants