You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
oauth2_proxy currently will silently fail to complete authentication if an invalid cookie name is set, perpetually redirecting the user back to the login screen with no errors logged.
This seems to be due to the behavior of Go's http.SetCookie method which according to the docs: The provided cookie must have a valid Name. Invalid cookies may be silently dropped.. Since oauth2_proxy's authentication relies on setting a cookie, there should be validation that the MakeCookie method makes a valid cookie, and subsequently, that the Set-Cookie header is actually included in the response headers.
The text was updated successfully, but these errors were encountered:
oauth2_proxy currently will silently fail to complete authentication if an invalid cookie name is set, perpetually redirecting the user back to the login screen with no errors logged.
This seems to be due to the behavior of Go's http.SetCookie method which according to the docs:
The provided cookie must have a valid Name. Invalid cookies may be silently dropped.
. Since oauth2_proxy's authentication relies on setting a cookie, there should be validation that theMakeCookie
method makes a valid cookie, and subsequently, that the Set-Cookie header is actually included in the response headers.The text was updated successfully, but these errors were encountered: