Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Checkbox select all tooltip #227

Closed
arucar opened this issue Apr 27, 2020 · 9 comments · Fixed by #228
Closed

[FEATURE] Checkbox select all tooltip #227

arucar opened this issue Apr 27, 2020 · 9 comments · Fixed by #228

Comments

@arucar
Copy link
Contributor

arucar commented Apr 27, 2020

Is it possible to add an @input to set text of a MatTooltip on the checkbox to select/unselect all ?

@macjohnny
Copy link
Member

@arucar yes, feel free to open a PR

@arucar
Copy link
Contributor Author

arucar commented Apr 27, 2020

oh ok ^^... i'll do that, thanks

@arucar
Copy link
Contributor Author

arucar commented Apr 27, 2020

i'll probably look like a noob.. but.. i can't create a new branch to push the code... i get an access denied

@macjohnny
Copy link
Member

Simply fork the repository and create a branch in your fork

@arucar
Copy link
Contributor Author

arucar commented Apr 27, 2020

ok.. i start to feel terrible lol...
i have clone the repo with: git clone https://github.com/bithost-gmbh/ngx-mat-select-search.git
do a git checkout -b feature/add_tooltip_on_checkbox
and i try to do: git push --set-upstream origin feature/add_tooltip_on_checkbox

and get remote: Permission to bithost-gmbh/ngx-mat-select-search.git denied to arucar.

@arucar
Copy link
Contributor Author

arucar commented Apr 27, 2020

oh i just receive a token.. may be i need to activate something first ? it's my first contribution ^^

@arucar
Copy link
Contributor Author

arucar commented Apr 27, 2020

ok wait i have find a tuto to fork the repo ^^

@macjohnny
Copy link
Member

Simply click the „fork“ button on https://github.com/bithost-gmbh/ngx-mat-select-search

@arucar
Copy link
Contributor Author

arucar commented Apr 27, 2020

i think it's ok..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants