-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] 508/screen reader support for mat-select-search-input #137
Comments
sounds good. do you want to open a PR for this? |
Sure. I didn't fully build out the @input, but I will try that out and issue a PR with my changes. Thank you for the quick response |
reminder: please add the input to https://github.com/bithost-gmbh/ngx-mat-select-search/blob/master/README.md#inputs |
@tonyholt do you think you can implement/test this until tomorrow? if so, I would wait and include it in the next release. |
@macjohnny, we can wait until the next release. I'll hopefully create the PR soon. |
@tonyholt any update on this? |
Sorry for the delay on this. |
When utilizing the 508 testing tool WAVE for Chrome, there's an issue where the mat-select-search-input does not have a label. This may also be an issue when utilizing screen reading for the mat-select-search.
Could we add an @input string to optionally supply an aria-label for the mat-select-search input? We could default it to "dropdown search". This way, the screen readers and other 508 tools will not have issue with this textbox. I have a commit on a fork that illustrates where I'd like the input to be utilized:
https://github.com/tonyholt/ngx-mat-select-search/blob/6ec0468f8401d864d16660a607727115f4ecb468/src/app/mat-select-search/mat-select-search.component.html#L17
The text was updated successfully, but these errors were encountered: