Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Searching spinner #114

Closed
mstawick opened this issue Mar 6, 2019 · 2 comments · Fixed by #115
Closed

[FEATURE] Searching spinner #114

mstawick opened this issue Mar 6, 2019 · 2 comments · Fixed by #115
Labels
feature New feature or request

Comments

@mstawick
Copy link
Contributor

mstawick commented Mar 6, 2019

Is your feature request related to a problem? Please describe.
Display indication during async search operations

Describe the solution you'd like
New @Input searching: boolean = false could be added, which would cause a mat-spinner to be displayed as matSuffix, in the place where (x) clear icon is shown

Describe alternatives you've considered
Allow custom styling of the search input field, though this is more complex.

Additional context
When search needs to hit the server and involve debounce on typed in text, it's a much nicer experience when an indication is shown that something is happening.

If you think this can be added, I can code it.

@macjohnny
Copy link
Member

sounds good. looking forward to your PR

@macjohnny macjohnny added the feature New feature or request label Mar 6, 2019
@macjohnny
Copy link
Member

@mstawick this feature was released with version 1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants