For Cycle 55

[alvasw]

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

• BSQ requested: 9090.91
• USD requested: 13000
• BSQ rate: 1.43 USD per BSQ
• Previous compensation request (if applicable): For Cycle 54 #1439

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title	Team	USD	Link	Notes
bisq: PR Review bisq-network/bisq#6947	dev		bisq-network/bisq#6947	I reviewed this PR after it was merged.
bisq: PR Review bisq-network/bisq#6949	dev		bisq-network/bisq#6949	I reviewed this PR after it was merged.
bisq: PR Review bisq-network/bisq#6952	dev		bisq-network/bisq#6952	I reviewed this PR after it was merged.
bisq: PR Review bisq-network/bisq#6955	dev		bisq-network/bisq#6955	I reviewed this PR after it was merged.
bisq: PR Review bisq-network/bisq#6961	dev		bisq-network/bisq#6961	I reviewed this PR after it was merged.
bisq: PR Review bisq-network/bisq#6964	dev		bisq-network/bisq#6964	I reviewed this PR after it was merged and discovered some issues (see comment).
bisq: PR Review bisq-network/bisq#6965	dev		bisq-network/bisq#6965	I reviewed this PR after it was merged.
bisq: PR Review bisq-network/bisq#6968	dev		bisq-network/bisq#6968
bisq: PR Review bisq-network/bisq#6972	dev		bisq-network/bisq#6972
bisq: PR Review bisq-network/bisq#6994	dev		bisq-network/bisq#6994
bisq: PR Review bisq-network/bisq#6998	dev		bisq-network/bisq#6998
bisq: Add FilterManagerInitializationTests	dev		bisq-network/bisq#6976
bisq: Add FilterManagerAddFilterToNetworkTests	dev		bisq-network/bisq#6977	Add JUnit MockitoExtension library Config: Make configFile field private and add getter Write FilterManagerAddFilterToNetworkTests
bisq: Add FilterManagerMockedPrivilegeKeysTests	dev		bisq-network/bisq#6979	DevEnv: Make DEV_PRIVILEGE_PUB_KEY private and add getter DevEnv: Make DEV_PRIVILEGE_PRIV_KEY private and add getter DevEnv: Add static getDevPrivilegePubKeys() method Write FilterManagerMockedPrivilegeKeysTests
bisq: core: Don't add old filter to invalid filters if new signer banned	dev		bisq-network/bisq#6980	Before this change, the currentFilter will be added to the invalidFilters list after comparing both filters creation date and before checking whether the new filter was created by a banned signer. Note: The invalid filters list is only used on the security manager Bisq instances. This list is never read by regular user clients.
bisq: Add Mempool to Regtest Setup	dev		bisq-network/bisq#6981	It's hard to review and test PRs that rely on the mempool service, e.g. Display the reason for auto-disabling an open offer.. #6952. This change helps developers to quickly setup a mempool instance to locally test changes. Add ElectrumX Dockerfile Create regtest-mempool docker-compose .gitignore: Exclude regtest data directories
bisq: Create GetBlocksRequestHandler's reply list once	dev		bisq-network/bisq#6995	Previously, the onGetBlocksRequest method created an ArrayList and two LinkedList before creating the GetBlocksResponse. The first two lists were never used. PR #6947 introduced the second LinkedList creation. With this change, the GetBlocksRequestHandler only creates a single LinkedList.
bisq: Fix fee check crash on invalid JSON response	dev		bisq-network/bisq#6997	The initialSanityChecks method only checks whether the JSON response is null (HTTP request failed) or the response is empty (HTTP 200) before parsing the JSON response. A invalid JSON response would throw a JsonSyntaxException exception which the callers are not catching. Changes: Test OpenOffer FeeValidation NOT_CHECKED_YET status Test OpenOffer inital state Remove redundant OpenOffer intial state constructor The inital state is always OpenOffer.State.AVAILABLE. Add FeeValidationStatus.NOT_CHECKED_YET tests Add TxValidatorSanityCheckTests TxValidator: Fix fee check crash on invalid JSON response
bisq: TxValidator: Fix crash on invalid vin or vout JSON Array	dev		bisq-network/bisq#7000	The TxValidators getVinAndVout(...) method assumes that json.get("field").getAsJsonArray() returns null when the field is not a JSON array. The getAsJsonArray() throws an IllegalStateException exception, however. The IllegalStateException doesn't get caught by any caller. Changes: Run TxValidatorSanityCheckTests for maker and taker TxValidator: Add missing vin and vout tests TxValidator: Fix crash on invalid vin or vout JSON Array Based on #6997.
bisq: TxValidator: Fix crash on missing vin[0].prevout	dev		bisq-network/bisq#7003	The checkFeeAmountBTC method looks up the value field of the vin[0].prevout field without checking whether vin[0].prevout exists. When the field is missing JsonElement jsonVIn0Value = jsonVin0.getAsJsonObject("prevout").get("value"); (line 193) throws a NullPointerException. Changes: Test too few inputs in fee payment Test too few outputs in fee payment TxValidator: Fix crash on missing vin[0].prevout
bisq2: Packaging: Disable incompatible Windows resources	dev		bisq-network/bisq2#1552	We had the same bug in Bisq 1. See: bisq-network/bisq#6870
bisq2: Implement I2P Server	dev		bisq-network/bisq2#1591
bisq2: Implement I2P Client	dev		bisq-network/bisq2#1592
bisq2: Create PeerSocket abstraction for Tor and I2P	dev		bisq-network/bisq2#1593	Create PeerSocket interface for Tor/I2P abstraction Implement TorSocket (PeerSocket interface) Implement I2pSocket (PeerSocket interface) Switch to PeerSocket in NetworkEnvelopeSocket
bisq2: Add Tor Onion Address Verification to ConnectionHandshakeInitiator	dev		bisq-network/bisq2#1594
bisq2: Fix Oracle Node Docs	dev		bisq-network/bisq2#1606	Add JDK 11 installation to oracle_node docs oracle_node docs: Don't start Gradle Daemon for builds oracle_node docs: Add missing backslashes in run_daonode.sh
bisq2: Write Ansible Playbook for bisq-daonode	dev		bisq-network/bisq2#1607
bisq2: Create AddressOwnershipProofGenerator abstraction for Tor/I2P	dev		bisq-network/bisq2#1623	Create AddressOwnershipProofGenerator abstraction Move Tor Onion Verification to TorAddressOwnershipProofGenerator Implement I2pAddressOwnershipProofGenerator Migrate to AddressOwnershipProofGenerator
bisq2: Add Ansible Playbook for bisq-daonode	dev		bisq-network/bisq2#1628	Write Ansible Playbook for bisq-daonode ansible: Create daonode.service Call bisq-daonode directly in systemd service Add Metadata to Bisq DAO Node systemd service Set bisq-daonode Service Type Change bisq-daonode restart policy to always Run bisq-danonode as low-privileged user Set bisq-daonode's ProtectSystem policy to strict
	dev	13000		Total for items above.

[ghost]

Info

Read BSQ amount from summary: 9154.93
Read USD amount from summary: 13000
Read BSQ rate from summary: 1.43
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":13000}

Errors

ERROR: Total BSQ does not match the sum of line items:

• Summary total: 9154.93 BSQ
• Calculated total: 9090.91 BSQ

[alvasw]

329b20c2262ea940d37b990aab2e2c2df0a8b9de61f6c025cacfc3dec70b65dd

[ghost]

Issuance by Team:

team	amount BSQ	amount USD
dev	9090.91	13000.00

Total Issuance: 9090.91 BSQ (equivalent to: 13000.00 USD)

[MwithM]

Closed as accepted.