Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect peer account age is shown in portfolio view #2799

Closed
leshik opened this issue May 2, 2019 · 8 comments
Closed

Incorrect peer account age is shown in portfolio view #2799

leshik opened this issue May 2, 2019 · 8 comments

Comments

@leshik
Copy link
Contributor

leshik commented May 2, 2019

The history tab in portfolio shows my own trading account age in tooltips for all trades instead of the trading peers ones. The color of the avatar circle is also wrong. I don't have open trades right now, but I'm pretty sure I've seen it incorrect on both open and history tabs.

@ghost
Copy link

ghost commented May 2, 2019

Which Bisq version do you use ?

@leshik
Copy link
Contributor Author

leshik commented May 2, 2019

@HarryMacfinned latest, v1.0.1 (because what’s the point of using an old version?)

@ghost
Copy link

ghost commented May 2, 2019

From time to time we see users with quite old versions (and also some users compiling from sources).

I have also Bisq v1.0.1 (on Debian), and I cannot reproduce your issue.
In fact, I see nobody's account age, nor mine.

Why do you say that the colors of the avatar circle are wrong ?

If you could join a screencopy, it could help.

@leshik
Copy link
Contributor Author

leshik commented May 2, 2019

Well, I wouldn’t want to post my trading peers onion addresses. I feel this might be not a good idea from the privacy perspective.

I’m on macOS, but I believe it should be the same on Linux. When you hover the mouse on the avatar of your trading peer, it shows the tooltip with his onion address and his account age. The circle around avatar has the orange color for accounts newer than 30 days, blue for those who are 30-60 days old, and green for older than 2 months. This works in trading view, but not in portfolio.

@ghost
Copy link

ghost commented May 2, 2019

You are right. I got it.
Thanks for reporting. This is a question for the UI specialist @ripcurlx (ping).
Thanks.

@devinbileck
Copy link
Member

This may have already been resolved by #2753, which will be available in the next release.

@ripcurlx
Copy link
Contributor

ripcurlx commented May 2, 2019

Which might go live within the next couple of hours 😉

@ripcurlx
Copy link
Contributor

ripcurlx commented May 3, 2019

Should be fixed in https://github.com/bisq-network/bisq/releases/tag/v1.1.0. Please re-open if this issue still exists for you.

@ripcurlx ripcurlx closed this as completed May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants