Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Offer book" graph is showing inconsistent information #1525

Closed
fedegrc opened this issue Apr 30, 2018 · 4 comments
Closed

The "Offer book" graph is showing inconsistent information #1525

fedegrc opened this issue Apr 30, 2018 · 4 comments

Comments

@fedegrc
Copy link

fedegrc commented Apr 30, 2018

Hi, I'm creating this issue in order to propose a change to the graph located in the section "Market -> Offer book". First, I'll describe the issue I'm seeing using this graph:

issue

Following the table related to the Buy side of the previous graph:

issue2

The summation of all BTCs is 1.28 BTC. If we want to buy all BTCs, we should spend USD 12047.77, so the Price is 12047.77 / 1.28 = 9412.32. If we see the graph, it shows a Price of ~9760 instead of 9412.32

I have been working on a R function that could solve this issue and provide useful information. The result is this graph:

grafico-3

@ripcurlx ripcurlx added the in:gui label May 2, 2018
@ripcurlx
Copy link
Contributor

ripcurlx commented May 2, 2018

@fedegrc Thanks for pointing this out. I'll have to see how this is calculcated atm and will come back to this issue soon.

@fedegrc
Copy link
Author

fedegrc commented May 14, 2018

@ripcurlx , an easy way to see that the graph is wrong is recognizing that sometimes there is a vertical lines showing the same Price for two or more Amount in BTC, which is mathematically impossible (except if the vertical line is in the "first/best" value).

screenshot_20180514_160149

The Price col of the following table shows the correct values:

  USD    BTC  cumsum(USD) cumsum(BTC)   Price
 353.12 0.040    353.12     0.0400    8828.0000
1070.73 0.125   1070.73     0.1650    8629.3939
1056.80 0.125   1056.80     0.2900    8553.9655
2119.60 0.250   2119.60     0.5400    8518.9815
1059.80 0.125   1059.80     0.6650    8511.3534

@stale
Copy link

stale bot commented Jan 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jan 17, 2019
@stale
Copy link

stale bot commented Jan 25, 2019

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants