Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockconfirmation indicator is too large #1421

Closed
ManfredKarrer opened this issue Mar 5, 2018 · 4 comments · Fixed by #1426
Closed

Blockconfirmation indicator is too large #1421

ManfredKarrer opened this issue Mar 5, 2018 · 4 comments · Fixed by #1426
Assignees
Labels

Comments

@ManfredKarrer
Copy link
Contributor

The block confirmation indicator is now larger as it it in the current release version. IMO it is too large in relation to other icons.

screen shot 2018-03-05 at 10 55 52

@cbeams
Copy link
Contributor

cbeams commented Mar 6, 2018

Strongly agree. Have been meaning to create an issue about this. Thanks.

Incidentally, @ManfredKarrer, what is the droplet image intended to mean? It's not obvious to me at first glance.

@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 6, 2018

Didn't change anything about that on intend, but I'll re-size it to match the other icons. I think the difference is related to the fact, that the other icons are Fontawesome icons and resize with the font size and the block confirmation indicator is a regular graphic.

@ripcurlx
Copy link
Contributor

ripcurlx commented Mar 6, 2018

The problem is not with the indicator icon itself. It just renders dependent on the size that is available for this component. I could of course just lock the size to match the original one, but I'll have a look why the rows are rendering with a higher row height by default atm. I think it is because of the Hyperlink component that is now used in this table view.

@ManfredKarrer
Copy link
Contributor Author

@cbeams re "what is the droplet image intended to mean?" Its for fee burning. But yes it might not be the best icon, just wanted to make burning not too negative with ire icon or so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants