Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGN shown in Market/Spread but not in Buy/Sell BTC?! #1240

Closed
tr37ion opened this issue Jan 19, 2018 · 13 comments
Closed

NGN shown in Market/Spread but not in Buy/Sell BTC?! #1240

tr37ion opened this issue Jan 19, 2018 · 13 comments
Assignees

Comments

@tr37ion
Copy link

tr37ion commented Jan 19, 2018

I just saw that the new coin NGN is shown with one trade in Market/Spread while I can't find it in Buy/Sell BTC list. Am I missing something? - I added all ALT coins.

image

@ripcurlx
Copy link
Contributor

Need to do some investigation on how these two lists are synced atm. Did it solve itself after time?

@tr37ion
Copy link
Author

tr37ion commented Jan 22, 2018

Still missing with 0.6.4

@ripcurlx ripcurlx self-assigned this Jan 25, 2018
@ripcurlx
Copy link
Contributor

I do see it in my list.
bildschirmfoto 2018-01-25 um 17 27 25
Unfortunately I wasn't able to re-produce it atm. Will have a look if I'm able to add some safeguard functionality to force the synchronisation of these two lists. I'll keep you posted.

@tr37ion
Copy link
Author

tr37ion commented Jan 25, 2018

Yes, it is in Market/Spread popups. While it is missing in the other Buy BTC/Sell BTC popups.

@ripcurlx
Copy link
Contributor

ripcurlx commented Jan 30, 2018

@tr37ion: Finally I had time to look at the difference of the currency selector in the Offer book, in the Buy/Sell BTC tab and what is displayed in the Spread section. The big difference is that in the Buy/Sell BTC tab only currencies are displayed that are configured in the Settings section (fiat & crypto) and in the Offer book & Spread you only see currencies that have offers, no matter if you have selected them in your settings. This is quite confusing at the moment.

Maybe we should select all fiat & crypto currencies by default in the Settings and apply the filter everywhere? In the Offer book and Spread all currencies without offers are filtered out anyways and in the Buy/Sell BTC tab every currency would be shown in this scenario. This is a little bit overwhelming if you look at it within the list, but the default currency is selected by default anyways. Maybe adding the number of buy/sell offers per currency in this drop down would also help finding out the interesting ones. Still sorting it by available offers might be really hard if you want to create the first offer in your currency and have to scan through a really long list.

The other option could be that we apply the filter and keep the current list of most popular currencies from Settings. In this case you might miss out offers in currencies you haven't selected so far. Not sure if, besides curiosity, this is a real use-case. We could add the default currency selection in the user on-boarding so she'll see her required currency for sure and can add any other currency in the Settings or by clicking on the Edit currency list in the currency dropdowns. What do you think? Maybe @ManfredKarrer could give us his thoughts on this as well?

@ripcurlx
Copy link
Contributor

@tr37ion: So for your bug, do you have NGN selected in your currency list in Settings?

@ripcurlx
Copy link
Contributor

Maybe we should rename the Currency: label in front of the currency selector to Currency with offers: or something like that, so people are not confused if their currency is not available in this screen, as it is the first screen you'll see when starting up Bisq. If we have a different Setup Guide and exchange currency screen as mentioned in #1207 would solve this problem anyways.

@tr37ion
Copy link
Author

tr37ion commented Jan 30, 2018

@ripcurlx Yes, I added all currencies in Settings. Maybe use Offers for [currency].

@ripcurlx
Copy link
Contributor

I like the Offers for [currency] idea!

@ripcurlx
Copy link
Contributor

Btw. I was wrong with the offer book combo box (currency selector). Here all currencies that are configured in the Settings are shown no matter if an offer is available or not.

@stale
Copy link

stale bot commented Jan 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented Apr 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Apr 18, 2019
@stale
Copy link

stale bot commented Apr 25, 2019

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants