-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data source: DDInter #68
Comments
I can claim this ticket. |
emailed data owners to ask about providing mappings between DDinterIDs and DrugBank/ChEMBL/PubChem. |
Here's a parser I wrote with the data that's available so far. |
I was able to scrape additional information (PubChem, ChEMBL, DrugBank ids) from http://ddinter.scbdd.com/. Web scraper: https://github.com/mnarayan1/DDInter/blob/main/webscraper.py Updated parser: https://github.com/mnarayan1/DDInter/blob/main/parser.py Sample Record:
|
@mnarayan1 in https://github.com/mnarayan1/DDInter/blob/main/webscraper.py#L7, you hard code a range on DDInter identifiers. Is it possible to generalize that so that your parser would work seamlessly when/if DDInter is updated? Thinking of iterating until you get a 404, or perhaps basing the scaping based on DDInter values in the downloadable file? |
I've updated the scraper to iterate until a page doesn't exist. Let me know if there's anything else I should fix. |
Have you confirmed that all of the IDs run continuously with no interruption? For example, is there ever the case where DDInter1234 was retired or for some reason doesn't exist? |
So far, all of the IDs exist and run continuously. |
great, I think this data plugin is ready for @erikyao to deploy. In parallel, you can also start working on writing the SmartAPI / OpenAPI annotation, as described in https://github.com/biothings/BioThings_Explorer_TRAPI/blob/main/docs/README-writing-x-bte.md. That guide is a work in progress, so suggestions on improvements are welcome and questions can go to Colleen and/or Rohan. |
Hi @andrewsu, I am testing the parser and I think the field names |
Great point and good catch. Yes, let's go with |
Hi @mnarayan1, I found multiple documents with P.S. I have forked your repo to https://github.com/biothings/DDInter and made some changes. Please let me know if you want to work directly on that fork (I can make a PR on your request). |
@erikyao I updated my parser, so hopefully the problem should be fixed. Could you make a pull request so I can update my repo with the changes you made? Thanks! |
@mnarayan1 Please find the PR at mnarayan1/DDInter#1. Thanks! |
the PR above was merged and deployed. Next step is to write SmartAPI / x-bte annotation. |
As noted in the linked issue just above:
I think this parser should be updated to download and process all files corresponding to |
I updated the parser to download all the files in |
Checking with @mnarayan1 @andrewsu :
|
This API has been deployed to Prod, should the issue be closed? |
Yep, closing it now |
name: Curated Drug-Drug Interactions Database
url: http://ddinter.scbdd.com/
download: http://ddinter.scbdd.com/download/
license: CC-BY-NC-SA (http://ddinter.scbdd.com/terms/)
The text was updated successfully, but these errors were encountered: