From 04b6e7b4699e92de36b43ed26551dba6f1f9198d Mon Sep 17 00:00:00 2001 From: Antony David Date: Thu, 6 Feb 2025 08:18:43 +0100 Subject: [PATCH 1/3] fix(lint): add react domains to `useJsxKeyInIterable` --- .../src/lint/correctness/use_jsx_key_in_iterable.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs b/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs index 86258701c4b7..2e8edbc1dcc2 100644 --- a/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs +++ b/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs @@ -1,6 +1,6 @@ use crate::react::{is_react_call_api, ReactLibrary}; use crate::services::semantic::Semantic; -use biome_analyze::{context::RuleContext, declare_lint_rule, Rule, RuleDiagnostic}; +use biome_analyze::{context::RuleContext, declare_lint_rule, Rule, RuleDiagnostic, RuleDomain}; use biome_analyze::{RuleSource, RuleSourceKind}; use biome_console::markup; use biome_diagnostics::Severity; @@ -44,6 +44,7 @@ declare_lint_rule! { source_kind: RuleSourceKind::SameLogic, recommended: true, severity: Severity::Error, + domains: &[RuleDomain::React, RuleDomain::Next], } } From 21a6eec5f8bb59ae645e15f7603a9a4154fb6f38 Mon Sep 17 00:00:00 2001 From: Antony David Date: Thu, 6 Feb 2025 08:18:43 +0100 Subject: [PATCH 2/3] fix(lint): add react domains to `useJsxKeyInIterable` --- .../src/lint/correctness/use_jsx_key_in_iterable.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs b/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs index 86258701c4b7..1a2b872b0e21 100644 --- a/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs +++ b/crates/biome_js_analyze/src/lint/correctness/use_jsx_key_in_iterable.rs @@ -1,6 +1,6 @@ use crate::react::{is_react_call_api, ReactLibrary}; use crate::services::semantic::Semantic; -use biome_analyze::{context::RuleContext, declare_lint_rule, Rule, RuleDiagnostic}; +use biome_analyze::{context::RuleContext, declare_lint_rule, Rule, RuleDiagnostic, RuleDomain}; use biome_analyze::{RuleSource, RuleSourceKind}; use biome_console::markup; use biome_diagnostics::Severity; @@ -44,6 +44,7 @@ declare_lint_rule! { source_kind: RuleSourceKind::SameLogic, recommended: true, severity: Severity::Error, + domains: &[RuleDomain::React], } } From 8486c100bb9d729821f9b11758c7de75cfbaf6bd Mon Sep 17 00:00:00 2001 From: Antony David Date: Thu, 6 Feb 2025 10:35:42 +0100 Subject: [PATCH 3/3] chore: changeset --- .changeset/dull-gorillas-juggle.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/dull-gorillas-juggle.md diff --git a/.changeset/dull-gorillas-juggle.md b/.changeset/dull-gorillas-juggle.md new file mode 100644 index 000000000000..d5f31fbb8a7c --- /dev/null +++ b/.changeset/dull-gorillas-juggle.md @@ -0,0 +1,5 @@ +--- +"@biomejs/biome": patch +--- + +Fix [#5024](https://github.com/biomejs/biome/issues/5024), add `useJsxKeyInIterable` rule to React domain.