Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biome 1.9.4 does not work for multi root workspaces => downgrade to 1.9.3 #5060

Closed
3 tasks done
Aetherall opened this issue Jan 19, 2025 · 6 comments
Closed
3 tasks done
Labels
S-Needs repro Status: needs a reproduction S-Needs response Status: await response from OP

Comments

@Aetherall
Copy link

VS Code version

all

Extension version

all

Biome version

1.9.4

Operating system

  • Windows
  • macOS
  • Linux

Description

Not really an issue with the extension, but with biome itself.
Biome 1.9.4 lsp-proxy ignores the --config-path argument.

I make an issue here because it is fixed already but not yet released, and people will look for issues here.

Steps to reproduce

.

Expected behavior

Maybe adding a warning statement when using multi-root and version 1.9.4, but really just waiting for the release will fix that

Does this issue occur when using the CLI directly?

Not sure / Not applicable

Link to a minimal reproduction

No response

Logs


@nhedger
Copy link
Member

nhedger commented Jan 19, 2025

This should only impact the pre-release extension, because the stable extension does not use lsp-proxy, but a socket.

@Aetherall Aetherall changed the title 🐛 Biome 1.9.4 does not work for multi root workspaces => downgrade to 1.9.3 🐛 [PreRelease] Biome 1.9.4 does not work for multi root workspaces => downgrade to 1.9.3 Jan 20, 2025
@Muscot
Copy link

Muscot commented Jan 27, 2025

I'm using only the stable version of the extension and on biome 1.9.4, I have this problem that the config file is not loaded. I found that if i run the cmd "Restart LSP server" it loads the config and start working again for a while :-)

@bradleysmagacz
Copy link

I have the same issue with 1.9.4 in a monorepo. Worked just fine with 1.8.3

@nhedger nhedger changed the title 🐛 [PreRelease] Biome 1.9.4 does not work for multi root workspaces => downgrade to 1.9.3 Biome 1.9.4 does not work for multi root workspaces => downgrade to 1.9.3 Feb 7, 2025
@nhedger nhedger transferred this issue from biomejs/biome-vscode Feb 7, 2025
@ematipico
Copy link
Member

ematipico commented Feb 10, 2025

I just tested core, and the configuration is correctly taken into account.

I would appreciate if some could share the daemon logs https://biomejs.dev/guides/editors/create-a-extension/#daemon-logs and a valid reproduction

@ematipico ematipico added S-Needs repro Status: needs a reproduction S-Needs response Status: await response from OP labels Feb 10, 2025
Copy link
Contributor

Hello @Aetherall, please provide a minimal reproduction. You can use one of the following options:

  • Provide a link to our playground, if it's applicable.
  • Provide a link to GitHub repository. To easily create a reproduction, you can use our interactive CLI via npm create @biomejs/biome-reproduction

Issues marked with S-Needs repro will be closed if they have no activity within 3 days.

@Aetherall
Copy link
Author

This issue was a consequence of #4834
so I think we can close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Needs repro Status: needs a reproduction S-Needs response Status: await response from OP
Projects
None yet
Development

No branches or pull requests

5 participants