Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 biome lsp won't let go of package.json file #5002

Closed
1 task done
Zooce opened this issue Jan 31, 2025 · 6 comments
Closed
1 task done

🐛 biome lsp won't let go of package.json file #5002

Zooce opened this issue Jan 31, 2025 · 6 comments
Labels
S-Needs response Status: await response from OP S-Needs triage Status: this issue needs to be triaged

Comments

@Zooce
Copy link

Zooce commented Jan 31, 2025

Environment information

CLI:
Version:                      1.9.4
Color support:                true

Platform:
CPU Architecture:             x86_64
OS: windows

Environment:
BIOME_LOG_PATH:               unset
BIOME_LOG_PREFIX_NAME:        unset
BIOME_CONFIG_PATH:            unset
NO_COLOR:                     unset
TERM:                         "xterm-256color"
JS_RUNTIME_VERSION:           "v20.15.0"
JS_RUNTIME_NAME:              "node"
NODE_PACKAGE_MANAGER:         "npm/10.9.2"

Biome Configuration:
Status:                       Loaded successfully
Formatter disabled:           false
Linter disabled:              false
  Organize imports disabled:  false
VCS disabled:                 false

Workspace:
Open Documents:               0

What happened?

Prerequisites:

  1. In Neovim, use Mason to install the biome lsp

Steps:

  1. Open Neovim in an Angular project
  2. Open any files that biome recognizes, like a TypeScript file
  3. Do a rebase of your git branch onto another

You'll see the following error:

Unlink of file 'package.json' failed. Should I try again? (y/n)
  1. Quit Neovim
  2. Try the rebase again and you'll see the same "unlink" error for package.json

Use any process explorer to find the biome.exe process still running and still has a hold of package.json.

Expected result

The biome lsp should not hold onto the packge.json (or any file), and I should be able to run any git operation.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Zooce Zooce added the S-Needs triage Status: this issue needs to be triaged label Jan 31, 2025
@ematipico
Copy link
Member

Biome LSP is very generic, and works for every client that supports it. I have never faced such issue in VSCode, Zed and IntelliJ. Is it possible that it's neovim/Mason doing something weird?

@ematipico ematipico added the S-Needs response Status: await response from OP label Jan 31, 2025
@Zooce
Copy link
Author

Zooce commented Jan 31, 2025

Is it possible that it's neovim/Mason doing something weird?

Certainly, I just don't quite know where to start looking...

@ematipico
Copy link
Member

It's weird that it happens only with the package.json and not the other files though 🤔

@Zooce
Copy link
Author

Zooce commented Jan 31, 2025

Okay so I just uninstalled the biome lsp, and now it's ngserver holding the file. These processes were all started with node ... so I think it's something there.

This issue can probably be closed. Thanks for the help...and my apologies for the wasted time.

@dyc3
Copy link
Contributor

dyc3 commented Jan 31, 2025

No worries!

@dyc3 dyc3 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2025
@ematipico
Copy link
Member

No apologies needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Needs response Status: await response from OP S-Needs triage Status: this issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants