Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed Types and Regular Imports When Sorting #4257

Closed
1 task done
artola opened this issue Oct 11, 2024 · 2 comments
Closed
1 task done

Mixed Types and Regular Imports When Sorting #4257

artola opened this issue Oct 11, 2024 · 2 comments
Labels
S-Needs triage Status: this issue needs to be triaged

Comments

@artola
Copy link

artola commented Oct 11, 2024

Environment information

CLI:
  Version:                      1.9.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.13.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/4.5.0"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Formatter:
  Format with errors:           false
  Indent style:                 Space
  Indent width:                 2
  Line ending:                  Lf
  Line width:                   80
  Attribute position:           Auto
  Bracket spacing:              BracketSpacing(false)
  Ignore:                       []
  Include:                      []

JavaScript Formatter:
  Enabled:                      false
  JSX quote style:              Double
  Quote properties:             AsNeeded
  Trailing commas:              All
  Semicolons:                   Always
  Arrow parentheses:            Always
  Bracket spacing:              unset
  Bracket same line:            false
  Quote style:                  Single
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Attribute position:           unset

JSON Formatter:
  Enabled:                      true
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Trailing Commas:              unset

CSS Formatter:
  Enabled:                      false
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Quote style:                  Single

GraphQL Formatter:
  Enabled:                      false
  Indent style:                 unset
  Indent width:                 unset
  Line ending:                  unset
  Line width:                   unset
  Bracket spacing:              unset
  Quote style:                  unset

Workspace:
  Open Documents:               0

Configuration

{
  "$schema": "https://biomejs.dev/schemas/1.9.3/schema.json",
  "vcs": {
    "enabled": true,
    "clientKind": "git",
    "defaultBranch": "master",
    "useIgnoreFile": true
  },
  "files": {
    "ignoreUnknown": true,
    "ignore": []
  },
  "formatter": {
    "enabled": true,
    "formatWithErrors": false,
    "indentStyle": "space",
    "indentWidth": 2,
    "lineEnding": "lf",
    "lineWidth": 80,
    "attributePosition": "auto",
    "bracketSpacing": false
  },
  "organizeImports": {
    "enabled": true
  },
  "linter": {
    "enabled": true,
    "rules": {
      "recommended": true,
      "a11y": {
        "useAriaPropsForRole": "off",
        "useFocusableInteractive": "off",
        "useSemanticElements": "off"
      },
      "correctness": {
        "useExhaustiveDependencies": "off"
      },
      "style": {
        "useFilenamingConvention": {
          "level": "error",
          "options": {
            "strictCase": false,
            "requireAscii": true,
            "filenameCases": ["kebab-case", "PascalCase", "export"]
          }
        },
        "useImportType": "off",
        "noNonNullAssertion": "off",
        "noParameterAssign": "off"
      },
      "suspicious": {
        "noExplicitAny": "off"
      }
    }
  },
  "assists": {
    "enabled": true,
    "actions": {
      "source": {
        "sortJsxProps": "off",
        "useSortedKeys": "off"
      }
    }
  },
  "javascript": {
    "formatter": {
      "jsxQuoteStyle": "double",
      "quoteProperties": "asNeeded",
      "trailingCommas": "all",
      "semicolons": "always",
      "arrowParentheses": "always",
      "bracketSameLine": false,
      "quoteStyle": "single"
    }
  },
  "css": {
    "formatter": {
      "quoteStyle": "single"
    }
  }
}

Playground link

https://biomejs.dev/playground/?lintRules=all&code=aQBtAHAAbwByAHQAIAB7AAoAIAAgAHQAeQBwAGUAIABTAG8AcgB0AEQAZQBzAGMAcgBpAHAAdABvAHIALAAKACAAIABDAGUAbABsACwACgAgACAAUgBlAHMAaQB6AGEAYgBsAGUAVABhAGIAbABlAEMAbwBuAHQAYQBpAG4AZQByACwACgAgACAAUgBlAHMAaQB6AGUAUwBvAHIAdABDAG8AbAB1AG0AbgAsAAoAIAAgAFIAbwB3ACwACgAgACAAVABhAGIAbABlACwACgAgACAAVABhAGIAbABlAEIAbwBkAHkALAAKACAAIABUAGEAYgBsAGUASABlAGEAZABlAHIALAAKAH0AIABmAHIAbwBtACAAJwBAAC8AVABhAGIAbABlACcAOwAKAAoALwAvACAAdAB5AHAAZQAgAGkAbQBwAG8AcgB0AHMAIABzAGgAbwB1AGwAZAAgAGIAZQAgAGMAbwBuAHMAaQBkAGUAcgBlAGQAIABhACAAZwByAG8AdQBwACAAZABpAGYAZgBlAHIAZQBuAHQAIAB0AGgAYQBuACAAbgBvAG4AIAB0AHkAcABlAC4ACgA%3D

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@artola artola added the S-Needs triage Status: this issue needs to be triaged label Oct 11, 2024
@Conaclos
Copy link
Member

This is intended by design. The type keyword doesn't affect sorting.

@artola
Copy link
Author

artola commented Oct 11, 2024

This is intended by design. The type keyword doesn't affect sorting.

GTK. It could make sense, but it seems a bit weird until I get used to it.

@artola artola closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Needs triage Status: this issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants