Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up Kanban board #34

Closed
bilalrajput09 opened this issue Jul 17, 2023 · 7 comments
Closed

set up Kanban board #34

bilalrajput09 opened this issue Jul 17, 2023 · 7 comments

Comments

@bilalrajput09
Copy link
Owner

@KanzaTahreem
Copy link

Changes Required 🔁

Hi @team

Good job so far ! I really appreciate the effort you put in! However, there are few this that still need to be fixed. But you are almost there! 💪 🏁

so close

Highlights 🎯

There are some excellent points that you have made perfectly. Keep up the great work! 👏

  • ✅ Well organized cards
  • ✅ Cards have points in the [Xpt] prefix
  • ✅ Excellent description of the tasks

Required Changes 🛑

  • I noticed that an issue is present for for the following requirement, but a corresponding card is missing. Please make sure to add a card for third team member, @mohamedSabry0

image

Optional suggestions ❕

N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👨‍💻💻

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@bilalrajput09
Copy link
Owner Author

image

@bilalrajput09
Copy link
Owner Author

Fixed!!!

@TedLivist
Copy link

STATUS: CHANGES REQUIRED ♻️ ♻️

Hi @bilalrajput09, @mohamedSabry0 and @AFakhriddinov,

Good job so far!
✔️ Kanban columns are complete
✔️ Tasks are well assigned
However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

  • You are yet to fix the issue pointed out by the previous reviewer. If you filter out the tasks for the third partner, @mohamedSabry0, (you can visit the filter here). The task not part of his assignments. This is because that task is not part of the Kanban project. You need to add the issue to be a part of the Kanban project.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@bilalrajput09
Copy link
Owner Author

image

@bilalrajput09
Copy link
Owner Author

Fixed!!!

@ichala
Copy link

ichala commented Jul 17, 2023

Hi Student ,

Status: Approved ✔️ ✔️ ✔️

68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f6c3366516333614356304871707a5763552f67697068792e676966

To Highlight 💪🏻

  • Changes Implemented ✔️

Good job implementing the requirements 👍 Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Optional Suggestions :

  • N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag ichala in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants