-
Notifications
You must be signed in to change notification settings - Fork 41
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
proof-of-concept for a plugin system.
- Loading branch information
1 parent
7b4f427
commit 86374c5
Showing
4 changed files
with
271 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,209 @@ | ||
describe("Plugin system", function () { | ||
setup(); | ||
|
||
afterEach(() => { | ||
const obj = Idiomorph.plugins; | ||
for (const key in obj) { | ||
if (obj.hasOwnProperty(key)) { | ||
delete obj[key]; | ||
} | ||
} | ||
}); | ||
|
||
it("can add plugins", function () { | ||
let calls = []; | ||
|
||
const plugin = { | ||
name: "foo", | ||
beforeNodeAdded: function (node) { | ||
calls.push(["beforeNodeAdded", node.outerHTML]); | ||
}, | ||
afterNodeAdded: function (node) { | ||
calls.push(["afterNodeAdded", node.outerHTML]); | ||
}, | ||
}; | ||
Idiomorph.addPlugin(plugin); | ||
Idiomorph.plugins.foo.should.equal(plugin); | ||
|
||
Idiomorph.morph(make("<p>"), "<p><hr>"); | ||
|
||
calls.should.eql([ | ||
["beforeNodeAdded", "<hr>"], | ||
["afterNodeAdded", "<hr>"], | ||
]); | ||
}); | ||
|
||
it("can add multiple plugins", function () { | ||
let calls = []; | ||
|
||
const plugin1 = { | ||
name: "foo", | ||
beforeNodeAdded: function (node) { | ||
calls.push(["beforeNodeAdded1", node.outerHTML]); | ||
}, | ||
afterNodeAdded: function (node) { | ||
calls.push(["afterNodeAdded1", node.outerHTML]); | ||
}, | ||
}; | ||
Idiomorph.addPlugin(plugin1); | ||
|
||
const plugin2 = { | ||
name: "bar", | ||
beforeNodeAdded: function (node) { | ||
calls.push(["beforeNodeAdded2", node.outerHTML]); | ||
}, | ||
afterNodeAdded: function (node) { | ||
calls.push(["afterNodeAdded2", node.outerHTML]); | ||
}, | ||
}; | ||
Idiomorph.addPlugin(plugin2); | ||
|
||
Idiomorph.plugins.foo.should.equal(plugin1); | ||
Idiomorph.plugins.bar.should.equal(plugin2); | ||
|
||
Idiomorph.morph(make("<p>"), "<p><hr>"); | ||
|
||
calls.should.eql([ | ||
["beforeNodeAdded1", "<hr>"], | ||
["beforeNodeAdded2", "<hr>"], | ||
["afterNodeAdded2", "<hr>"], | ||
["afterNodeAdded1", "<hr>"], | ||
]); | ||
}); | ||
|
||
it("can add multiple plugins alongside callbacks", function () { | ||
let calls = []; | ||
|
||
const plugin1 = { | ||
name: "foo", | ||
beforeNodeAdded: function (node) { | ||
calls.push(["beforeNodeAdded1", node.outerHTML]); | ||
}, | ||
afterNodeAdded: function (node) { | ||
calls.push(["afterNodeAdded1", node.outerHTML]); | ||
}, | ||
}; | ||
Idiomorph.addPlugin(plugin1); | ||
|
||
const plugin2 = { | ||
name: "bar", | ||
beforeNodeAdded: function (node) { | ||
calls.push(["beforeNodeAdded2", node.outerHTML]); | ||
}, | ||
afterNodeAdded: function (node) { | ||
calls.push(["afterNodeAdded2", node.outerHTML]); | ||
}, | ||
}; | ||
Idiomorph.addPlugin(plugin2); | ||
|
||
Idiomorph.plugins.foo.should.equal(plugin1); | ||
Idiomorph.plugins.bar.should.equal(plugin2); | ||
|
||
Idiomorph.morph(make("<p>"), "<p><hr>", { | ||
callbacks: { | ||
beforeNodeAdded: function (node) { | ||
calls.push(["beforeNodeAddedCallback", node.outerHTML]); | ||
}, | ||
afterNodeAdded: function (node) { | ||
calls.push(["afterNodeAddedCallback", node.outerHTML]); | ||
}, | ||
}, | ||
}); | ||
|
||
calls.should.eql([ | ||
["beforeNodeAdded1", "<hr>"], | ||
["beforeNodeAdded2", "<hr>"], | ||
["beforeNodeAddedCallback", "<hr>"], | ||
["afterNodeAddedCallback", "<hr>"], | ||
["afterNodeAdded2", "<hr>"], | ||
["afterNodeAdded1", "<hr>"], | ||
]); | ||
}); | ||
|
||
it("the first beforeNodeAdded => false halts the entire operation", function () { | ||
let calls = []; | ||
|
||
const plugin1 = { | ||
name: "foo", | ||
beforeNodeAdded: function (node) { | ||
calls.push(["beforeNodeAdded1", node.outerHTML]); | ||
return false; | ||
}, | ||
afterNodeAdded: function (node) { | ||
calls.push(["afterNodeAdded1", node.outerHTML]); | ||
}, | ||
}; | ||
Idiomorph.addPlugin(plugin1); | ||
|
||
const plugin2 = { | ||
name: "bar", | ||
beforeNodeAdded: function (node) { | ||
calls.push(["beforeNodeAdded2", node.outerHTML]); | ||
}, | ||
afterNodeAdded: function (node) { | ||
calls.push(["afterNodeAdded2", node.outerHTML]); | ||
}, | ||
}; | ||
Idiomorph.addPlugin(plugin2); | ||
|
||
Idiomorph.plugins.foo.should.equal(plugin1); | ||
Idiomorph.plugins.bar.should.equal(plugin2); | ||
|
||
Idiomorph.morph(make("<p>"), "<p><hr>", { | ||
callbacks: { | ||
beforeNodeAdded: function (node) { | ||
calls.push(["beforeNodeAddedCallback", node.outerHTML]); | ||
}, | ||
afterNodeAdded: function (node) { | ||
calls.push(["afterNodeAddedCallback", node.outerHTML]); | ||
}, | ||
}, | ||
}); | ||
|
||
calls.should.eql([ | ||
["beforeNodeAdded1", "<hr>"] | ||
]); | ||
}); | ||
|
||
it("plugin callbacks are not all required to exist", function () { | ||
let calls = []; | ||
|
||
const plugin1 = { | ||
name: "foo", | ||
beforeNodeAdded: function (node) { | ||
calls.push(["beforeNodeAdded1", node.outerHTML]); | ||
}, | ||
afterNodeAdded: function (node) { | ||
calls.push(["afterNodeAdded1", node.outerHTML]); | ||
}, | ||
}; | ||
Idiomorph.addPlugin(plugin1); | ||
|
||
const plugin2 = { | ||
name: "bar", | ||
}; | ||
Idiomorph.addPlugin(plugin2); | ||
|
||
Idiomorph.plugins.foo.should.equal(plugin1); | ||
Idiomorph.plugins.bar.should.equal(plugin2); | ||
|
||
Idiomorph.morph(make("<p>"), "<p><hr>", { | ||
callbacks: { | ||
beforeNodeAdded: function (node) { | ||
calls.push(["beforeNodeAddedCallback", node.outerHTML]); | ||
}, | ||
afterNodeAdded: function (node) { | ||
calls.push(["afterNodeAddedCallback", node.outerHTML]); | ||
}, | ||
}, | ||
}); | ||
|
||
calls.should.eql([ | ||
["beforeNodeAdded1", "<hr>"], | ||
["beforeNodeAddedCallback", "<hr>"], | ||
["afterNodeAddedCallback", "<hr>"], | ||
["afterNodeAdded1", "<hr>"], | ||
]); | ||
}); | ||
}); | ||
|