Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AWS dependency #41

Closed
fnothaft opened this issue Jun 2, 2015 · 7 comments
Closed

Remove AWS dependency #41

fnothaft opened this issue Jun 2, 2015 · 7 comments

Comments

@fnothaft
Copy link
Member

fnothaft commented Jun 2, 2015

See discussion in bigdatagenomics/adam#690.

We depend on the AWS SDK for the Serializable AWS credentials. I believe that this is dead code.

@heuermh
Copy link
Member

heuermh commented Jul 10, 2015

re: bigdatagenomics/adam#690 (comment)

Taking a quick look at this, it looks generally useful and as such might still make sense in a utils module. Was the old S3 Parquet loader you refer to replaced by something else?

@fnothaft
Copy link
Member Author

What is useful about this? The AWS SDK? Any downstream project can just depend on AWS independently.

@heuermh
Copy link
Member

heuermh commented Jul 10, 2015

I'm seeing classes CredentialsProperties, S3ByteAccess, S3FileLocator, SerializableAWSCredentials. Even if no longer used in ADAM they seem generally useful.

@fnothaft
Copy link
Member Author

Ah, gotcha. I'm not much of a fan of letting dead code that adds a dependency stay in the repository. If we need the code at a later date, we can always revert the commit that removed it.

@heuermh
Copy link
Member

heuermh commented Jul 10, 2015

ok, then there's just the binary compatibility argument, which I'm not sure applies to these 0.x-versioned projects yet :)

@fnothaft
Copy link
Member Author

Yeah, we're not concerned about that until 1.x.

@fnothaft
Copy link
Member Author

Closed by 2b4c154.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants