-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AWS dependency #41
Comments
re: bigdatagenomics/adam#690 (comment) Taking a quick look at this, it looks generally useful and as such might still make sense in a utils module. Was the old S3 Parquet loader you refer to replaced by something else? |
What is useful about this? The AWS SDK? Any downstream project can just depend on AWS independently. |
I'm seeing classes CredentialsProperties, S3ByteAccess, S3FileLocator, SerializableAWSCredentials. Even if no longer used in ADAM they seem generally useful. |
Ah, gotcha. I'm not much of a fan of letting dead code that adds a dependency stay in the repository. If we need the code at a later date, we can always revert the commit that removed it. |
ok, then there's just the binary compatibility argument, which I'm not sure applies to these 0.x-versioned projects yet :) |
Yeah, we're not concerned about that until 1.x. |
Closed by 2b4c154. |
See discussion in bigdatagenomics/adam#690.
We depend on the AWS SDK for the Serializable AWS credentials. I believe that this is dead code.
The text was updated successfully, but these errors were encountered: