Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.12 / spark 2.4.4 release #215

Closed
ghost opened this issue Jan 4, 2020 · 5 comments · Fixed by #217
Closed

Scala 2.12 / spark 2.4.4 release #215

ghost opened this issue Jan 4, 2020 · 5 comments · Fixed by #217
Milestone

Comments

@ghost
Copy link

ghost commented Jan 4, 2020

I am looking get a release of this for scala 2.12. Do you know LOE here?

@heuermh
Copy link
Member

heuermh commented Jan 6, 2020

We have cross-Spark and -Scala build configuration support in the Cannoli build but it is not currently enabled. We should reenable it for Scala 2.12 and prepare for the upcoming Spark 3 release.

@ghost
Copy link
Author

ghost commented Jan 6, 2020

Ok sounds good. Friday I configured a 2.12 build that failed. Looks like you've already got a pr in the works for this though

@heuermh
Copy link
Member

heuermh commented Jan 6, 2020

Scala 2.12 uses Java 8-style lambdas for functions and that breaks some of our APIs at compile time, requiring the use of casts. When we no longer have to support Scala 2.11, we can drop those Java-friendly methods causing trouble under Scala 2.12+.

@heuermh
Copy link
Member

heuermh commented Jan 6, 2020

Scala 2.12 artifacts are now available in the Sonatype snapshots repository, e.g.

<dependency>
  <groupId>org.bdgenomics.cannoli</groupId>
  <artifactId>cannoli-core-spark2_2.12</artifactId>
  <version>0.9.0-SNAPSHOT</version>
</dependency>

@ghost
Copy link
Author

ghost commented Jan 6, 2020

Rad. I have some special snowflake settings on my spark build. Can I build this against my spark build via setting spark.version=2.12 when running mvn install?

EDIT: Ah nvm I see it's been merged. I'll build it from there. Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant