From fade6ee6d1938cbaae8b2072e337e5df6c1a496d Mon Sep 17 00:00:00 2001 From: "Andrew A. Barber" Date: Sat, 12 Aug 2023 13:39:16 +0100 Subject: [PATCH 1/4] Update Twitter / X Logo for Social Sharing and Social Links #2386 --- assets/icons/twitter.svg | 6 --- assets/icons/x.svg | 5 +++ assets/img/icon-sprite.svg | 2 +- templates/components/common/share.html | 10 ++--- templates/components/common/social-links.html | 42 +++++++++++++------ 5 files changed, 40 insertions(+), 25 deletions(-) delete mode 100755 assets/icons/twitter.svg create mode 100644 assets/icons/x.svg diff --git a/assets/icons/twitter.svg b/assets/icons/twitter.svg deleted file mode 100755 index 2bf4524c6a..0000000000 --- a/assets/icons/twitter.svg +++ /dev/null @@ -1,6 +0,0 @@ - - - - - - diff --git a/assets/icons/x.svg b/assets/icons/x.svg new file mode 100644 index 0000000000..18623b0729 --- /dev/null +++ b/assets/icons/x.svg @@ -0,0 +1,5 @@ + + + + + diff --git a/assets/img/icon-sprite.svg b/assets/img/icon-sprite.svg index 2b6c410d74..debb4aa553 100644 --- a/assets/img/icon-sprite.svg +++ b/assets/img/icon-sprite.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/templates/components/common/share.html b/templates/components/common/share.html index 414617e34c..2b03748628 100644 --- a/templates/components/common/share.html +++ b/templates/components/common/share.html @@ -43,16 +43,16 @@ {{else if service '===' 'twitter'}} - - {{{capitalize service}}} + X - + {{else if service '===' 'linkedin'}} diff --git a/templates/components/common/social-links.html b/templates/components/common/social-links.html index 9aba93ae66..2e19e958f3 100644 --- a/templates/components/common/social-links.html +++ b/templates/components/common/social-links.html @@ -1,19 +1,35 @@ {{#if social_media}} {{/if}} From e22a8ce8c7772ab0554bf2f1088f9d1e46168489 Mon Sep 17 00:00:00 2001 From: "Andrew A. Barber" Date: Sat, 12 Aug 2023 13:42:06 +0100 Subject: [PATCH 2/4] Update changelog #2386 --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1a5315db4e..e441f595a6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## Draft - +- Replace Twitter logo with X logo within social sharing and social link components [#2386] ## 6.12.0 (07-06-2023) - sync package lock file [#2373](https://github.com/bigcommerce/cornerstone/pull/2373) - Stored payment method name is not visible in Cornerstone Bold theme style [#2371](https://github.com/bigcommerce/cornerstone/pull/2371) From d2d8464b008fe2dc7dfc2c46f35ecab12b6dff14 Mon Sep 17 00:00:00 2001 From: "Andrew A. Barber" Date: Mon, 14 Aug 2023 10:55:38 +0100 Subject: [PATCH 3/4] Add links to changelog #2386 --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e441f595a6..6f1cc6841a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## Draft -- Replace Twitter logo with X logo within social sharing and social link components [#2386] +- Replace Twitter logo with X logo within social sharing and social link components [#2387](https://github.com/bigcommerce/cornerstone/pull/2387) + ## 6.12.0 (07-06-2023) - sync package lock file [#2373](https://github.com/bigcommerce/cornerstone/pull/2373) - Stored payment method name is not visible in Cornerstone Bold theme style [#2371](https://github.com/bigcommerce/cornerstone/pull/2371) From 56a336365a78e14b6ef12932acf8863b6eb549a3 Mon Sep 17 00:00:00 2001 From: "Andrew A. Barber" Date: Mon, 14 Aug 2023 11:49:28 +0100 Subject: [PATCH 4/4] Add static display_name to remove mention of Twttr #2386 --- templates/components/common/social-links.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/components/common/social-links.html b/templates/components/common/social-links.html index 2e19e958f3..7e746596c2 100644 --- a/templates/components/common/social-links.html +++ b/templates/components/common/social-links.html @@ -7,7 +7,7 @@ href="{{url}}" target="_blank" rel="noopener" - title="{{{capitalize display_name}}}" + title="X" > X