Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List View - Improve / Tidy Alignment #969

Closed
GeorgeLondon opened this issue Mar 17, 2017 · 4 comments
Closed

List View - Improve / Tidy Alignment #969

GeorgeLondon opened this issue Mar 17, 2017 · 4 comments

Comments

@GeorgeLondon
Copy link

Great to have a List View now, thanks (fixed in STENCIL-3194) - I've just activated it in our test store.

The layout of the columns on the List View is irregular, based on the size of the thumbnail and the amount of text in the description.

I suspect this could probably be resolved by imposing a width on the thumbnail image and on the Title & Description elements.

Screenshot below with red guidelines to show where sections are not aligned in the way I expect them to be.

image

This is even more pronounced on the Search Results page. Screenshot below with red guidelines.

image

Third screenshot from the Brands page.

image

All screenshots from Win10/Chrome.

@m0000g
Copy link

m0000g commented Mar 21, 2017

This could be fixed ... perhaps with flexbox?
I would love to help

@PreciselyAlyss
Copy link
Contributor

@m0000g Feel free! We welcome PRs :)

@GeorgeLondon
Copy link
Author

GeorgeLondon commented Mar 24, 2017

A little more info;

What appears to be happening is that some elements expand in response to the width of the browser, but they are not expanding uniformly down the page. The reason this was more pronounced on the Search Results page is because the content area on that page is effectively wider (because there is no LH block).

The issue is becoming less obvious as we have been going through the process of populating our products with (equal sized) images this week, but we are still seeing it.

@Ubersmake
Copy link
Contributor

I'm closing this issue mostly because of age. I'm hopeful that somewhere in the last year's worth of changes this issue was addressed. I certainly can't reproduce it anymore. One of these is likely to have contributed:

#1137 - Released in 1.11.0
#1033 - Released in 1.8.2
#980 - Released in 1.6.3

Cornerstone 1.6.3 was released on March 28, 2017.

For the record, this is what List View looks like now. The first image's source is very, very large and of different dimensions than everything else:

screen shot 2018-12-17 at 4 26 48 pm

@GeorgeLondon , @m0000g , please feel free to re-open this Issue if it isn't actually fixed on Cornerstone, which as of this writing is at 2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants