We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social sharing links on product pages should link to social sites with the url included
Social sharing links have the url as undefined
Browse to any product page and click on a social share link
addthis support was removed in #1997 and product.url is now passed in as url on line 252
product.url
url
#2077 fixed this for blog posts but breaks it for product pages. i believe the correct fix would be to pass in post.url as url to the share component
post.url
$ ag 'common/share' templates/components/products/product-view.html 279: {{> components/common/share url=product.url}} templates/components/blog/post.html 48: {{>components/common/share}} [some removed]
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Expected behavior
Social sharing links on product pages should link to social sites with the url included
Actual behavior
Social sharing links have the url as undefined
Steps to reproduce behavior
Browse to any product page and click on a social share link
References
addthis support was removed in #1997 and
product.url
is now passed in asurl
on line 252#2077 fixed this for blog posts but breaks it for product pages. i believe the correct fix would be to pass in
post.url
asurl
to the share componentThe text was updated successfully, but these errors were encountered: