fix(payments): PAYMENTS-4228 remove currency code for when ID already…

… provided
bigcommerce · May 21, 2019 · c9da8a8 · c9da8a8
1 parent 3100a8a
commit c9da8a8
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/src/store/store-request-sender.js b/src/store/store-request-sender.js
@@ -104,8 +104,7 @@ export default class StoreRequestSender {
         const url = this.urlHelper.getInstrumentByIdUrl(
             data.storeId,
             data.customerId,
-            data.instrumentId,
-            data.currencyCode
+            data.instrumentId
         );
         const options = {
             method: DELETE,

diff --git a/src/store/url-helper.js b/src/store/url-helper.js
@@ -58,10 +58,9 @@ export default class UrlHelper {
      * @param {number} storeId
      * @param {number} customerId
      * @param {number} instrumentId
-     * @param {string} currencyCode
      * @returns {string}
      */
-    getInstrumentByIdUrl(storeId, customerId, instrumentId, currencyCode) {
-        return `${this.host}/api/v2/stores/${storeId}/shoppers/${customerId}/instruments/${instrumentId}?currency_code=${currencyCode}`;
+    getInstrumentByIdUrl(storeId, customerId, instrumentId) {
+        return `${this.host}/api/v2/stores/${storeId}/shoppers/${customerId}/instruments/${instrumentId}`;
     }
 }
diff --git a/test/store/store-request-sender.spec.js b/test/store/store-request-sender.spec.js
@@ -80,8 +80,7 @@ describe('StoreRequestSender', () => {
         expect(urlHelperMock.getInstrumentByIdUrl).toHaveBeenCalledWith(
             data.storeId,
             data.customerId,
-            data.instrumentId,
-            data.currencyCode
+            data.instrumentId
         );
         expect(requestSenderMock.sendRequest).toHaveBeenCalled();
         expect(mappers.mapToHeaders).toHaveBeenCalled();

diff --git a/test/store/url-helper.spec.js b/test/store/url-helper.spec.js
@@ -48,8 +48,8 @@ describe('UrlHelper', () => {
     });
 
     it('returns a URL for generating a client token', () => {
-        const result = urlHelper.getInstrumentByIdUrl(storeId, shopperId, instrumentId, currencyCode);
-        const expected = `${host}/api/v2/stores/${storeId}/shoppers/${shopperId}/instruments/${instrumentId}?currency_code=${currencyCode}`;
+        const result = urlHelper.getInstrumentByIdUrl(storeId, shopperId, instrumentId);
+        const expected = `${host}/api/v2/stores/${storeId}/shoppers/${shopperId}/instruments/${instrumentId}`;
 
         expect(result).toEqual(expected);
     });