Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button web example on bevyengine.org clickable area is wrong (Regression?) #4963

Closed
paul-hansen opened this issue Jun 7, 2022 · 8 comments
Closed
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples O-Web Specific to web (WASM) builds

Comments

@paul-hansen
Copy link
Contributor

Bevy version

Whatever the examples are built with on the webpage: https://bevyengine.org/examples/ui/button/
Is not happening for me locally using Bevy 0.7

System information

Chrome Version 102.0.5005.63 (Official Build) (64-bit) on Windows 11

`AdapterInfo { name: "ANGLE (NVIDIA, NVIDIA GeForce RTX 3080 Direct3D11 vs_5_0 ps_5_0, D3D11)", vendor: 4318, device: 0, device_type: DiscreteGpu, backend: Gl }`

What you did

I opened https://bevyengine.org/examples/ui/button/ and tried clicking the button in the example.

What went wrong

The area that I can click the button is offset from the visual position of the button. It gets more offset (and maybe larger?) if the window is made smaller.

Additional information

Example:

video.mp4

I'm 90% sure this wasn't happening earlier today, so it might be something merged recently.

@paul-hansen paul-hansen added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jun 7, 2022
@paul-hansen
Copy link
Contributor Author

paul-hansen commented Jun 7, 2022

I just tried pulling the main branch and running the example locally using cargo run --release --target wasm32-unknown-unknown --example button and it seems to be working correctly.
Depending on what version the website uses, this may already be resolved.

@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples O-Web Specific to web (WASM) builds and removed S-Needs-Triage This issue needs to be labelled labels Jun 7, 2022
@alice-i-cecile alice-i-cecile added this to the Bevy 0.8 milestone Jun 7, 2022
@benbot
Copy link

benbot commented Jun 8, 2022

Yeah seems like @paul-hansen is right.
I'm seeing this same issue on the examples webpage (on firefox too, so a totally different browser), but not if i compile the lastest bevy example locally.

@mockersf
Copy link
Member

mockersf commented Jun 8, 2022

Depending on what version the website uses, this may already be resolved.

The website is using the last released version, 0.7 here

@hymm
Copy link
Contributor

hymm commented Jun 8, 2022

This looks like it might be a duplicate of bevyengine/bevy-website#371 and should have been fixed by #4726.

@paul-hansen
Copy link
Contributor Author

I agree that looks like the same thing and looks to be fixed in main now. Thanks for tracking that down 👍

I'll close this for now, feel free to reopen or anything though if you think something should be done before 0.8 releases.

@mockersf
Copy link
Member

mockersf commented Jun 8, 2022

#4726 probably didn't fix this as it's an optional behaviour that is not enabled by default

@alice-i-cecile alice-i-cecile reopened this Aug 2, 2022
@alice-i-cecile alice-i-cecile removed this from the Bevy 0.8 milestone Aug 2, 2022
@alice-i-cecile alice-i-cecile added the A-UI Graphical user interfaces, styles, layouts, and widgets label Aug 2, 2022
@alice-i-cecile
Copy link
Member

Reopened as we have a fresh reproduction.

@mockersf
Copy link
Member

mockersf commented Aug 2, 2022

issue is on the CSS of the website changing the size of the canvas, I opened bevyengine/bevy-website#429 to change that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples O-Web Specific to web (WASM) builds
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants