Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a par_iter method on Query #2649

Closed
alice-i-cecile opened this issue Aug 13, 2021 · 4 comments
Closed

Create a par_iter method on Query #2649

alice-i-cecile opened this issue Aug 13, 2021 · 4 comments
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

Getting data out of parallel iterators over Queries using par_for_each is very complex, due to limitations on ownership.

What solution would you like?

Create a par_map method on Query, which returns an iterator.

What alternative(s) have you considered?

Pre-allocate the data, then use par_for_each_mut to mutate the pre-allocated data.

@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled A-ECS Entities, components, systems, and events and removed S-Needs-Triage This issue needs to be labelled labels Aug 13, 2021
@TheRawMeatball
Copy link
Member

TheRawMeatball commented Aug 13, 2021

If it's returning an iterator, then it'd be more accurate to call it par_iter. Also, this is already pretty much there in my unkempt PR #2088

@TheRawMeatball
Copy link
Member

It's currently waiting on some sort of resolution to the problems outlined here: #2093 (comment)

@alice-i-cecile alice-i-cecile changed the title Create a par_map method on Query Create a par_iter method on Query Dec 12, 2021
@rparrett
Copy link
Contributor

Can this be closed?

@alice-i-cecile
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible
Projects
None yet
Development

No branches or pull requests

3 participants