Mesh format panics with enabled by default ShaderDef

[lassade]

Bevy version

master branch d9fb61d

Operating system & version

Windows 10 / Fedora ~31

What you did

Define a material:

#[derive(Debug, Clone, Reflect, RenderResources, ShaderDefs)]
#[reflect(Component)]
pub struct Material {
    /// Enabled by default
    #[shader_def]
    #[render_resources(ignore)]
    pub lit: bool,
}

and his respective shader

....
#ifndef MATERIAL_UNLIT // Unlit shader doesn't need normals
layout(location = 3) in vec3 Vertex_Normal;
layout(location = 2) out vec3 v_Normal;
#endif
....

Tried to spawn a mesh without the Vertex_Normal attribute and with the Material::unlit = true

What you expected to happen

The mesh should be rendered just fine

What actually happened

Panic, with a complain about the mesh missing the Vertex_Normal attribute;

Additional information

I mananged to fix this issue by making all defines off by default instead of on, so in this case I use #ifdef MATERIAL_LIT instead

[cart]

I can't repro this using the internal StandardMaterial using any permutation of:

1. changing unlit to lit
2. changing the default value of StandardMaterial::lit to true or false
3. Using # ifndef or # ifdef in forward.frag

Can you attach a minimal example that repros the issue?

[lassade]

You should be able to reproduce the error by runing cargo run --example showcase using the repo https://github.com/lassade/bevy_gizmos/tree/issue-1589 make sure to get the issue-1589 branch

Edit
A quick and dirt update to 1e42de6 still panics

[james7132]

Closing this as both RenderResources and ShaderDefs are no longer present in the post-0.6 renderer.