Bug: Custom StoreProtocol doesnt store

[mpvanderschelling]

The problem

When using a custom StoreProtocol, the store method is never run, only an instance of the StoreProtocol is created (in line 324)

f3dasm/src/f3dasm/_src/experimentdata/_io.py

Lines 321 to 339 in 8b8b744

	_path = experimentdata_directory / path
	if store_method is not None:
	storage = store_method(object, _path)
	return
	# Check if object type is supported
	object_type = type(object)
	if object_type not in STORE_TYPE_MAPPING:
	storage: StoreProtocol = PickleStore(object, _path)
	logger.debug(f"Object type {object_type} is not natively supported. "
	f"The default pickle storage method will be used.")
	else:
	storage: StoreProtocol = STORE_TYPE_MAPPING[object_type](object, _path)
	# Store object
	storage.store()
	return storage.suffix

Solution

Don't return, but let storage.store() be executed whenever a StoreProtocol is instantiated.