-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small issue: Image missing #37
Comments
On the right is it probably because there isnt an image coming back from the api for your device. Can you turn on debug logging and take a look at one of the json dumps to see if there is a url in it. With the image on the left, I need to submit an image to the cental home assistant repo, I have send the PR home-assistant/brands#4601 |
It turns out I am actually getting a bunch of errors in the logs. I did notice a URL with a mention of "hero". I also noticed that my ecobee is popping up in there. I recently linked my ecobee and Generac accounts so that the generator status displays on my ecobee thermostat. There is a lot more than this in the logs, but I figured it was just being repeated and you didn't need all of it. Please let me know if there is any other information I can provide.
|
Sorry, one more thing. This was in my log as well, which may be the image culprit. 2023-08-12 21:06:26.766 ERROR (MainThread) [homeassistant.components.image] image.generac_560359_hero_image: Image from https://gpsprodmobilelink.blob.core.windows.net/apparatusimage/G0070433.jpg has invalid content type: application/octet-stream |
ah that would be it, I didnt know they could use a jpg. I will look into a fix |
Reopening to track home-assistant/brands#4601 |
Thanks for hopping on this so quickly! The error in the log is gone, and it looks like everything is showing up now! But question - Under "Controls" I have the picture of the generator, but there are no actual controls. Just curious what this is for? And another question: Is there a way to configure the integration to poll more frequently? My generator performed its Exercising routine today from 12:00-12:05, but these events were not captured until 1-2 minutes later. I wondered if it might be configurable from the main integration configuration screen, but instead I noticed some checkboxes with blanks next to them |
@bentekkie Just wanted to check in to see if you saw my last comment about poling and the configuration screen? No rush on anything! I very much appreciate all of your efforts on this! Just wanted to make sure it wasn't missed. Thanks! |
Hi @bentekkie - Just checking in to see if you had any additional thoughts on my polling questions above? Thanks! |
@mikesalz the current polling interval seems to be 30 seconds. I'm not sure if the API has rate limiting in place that would prevent you from decreasing this to say 5 seconds, but I would also suspect that the generator itself has a ~10-30 second delay of reporting it's current status to the cloud server behind the API. I'd be glad to help make that value configurable though if you'd like to give it a shot. As mentioned in #56 (comment), I've created a fork that some users have switched over to, which fixes some existing issues already. |
@binarydev Thanks for letting me know about your fork! Nice to see that someone else is now continuing efforts on this integration. I will check out your fork later today when I have some time. I appreciate it! I would be interested to see if changing the polling could help a little. I am regularly getting about a 2 minute delay. In the grand scheme of things it's not a huge issue, but it would be great if I could get it a little closer to real time. Are you also getting the checkbox weirdness in the main integration configuration screen? I have a screen shot a couple of comments above. |
Yup I am indeed! Trying to clean that up while adding the new polling interval config option. |
Hi @binarydev - I switched over to your fork. So far it is working mostly well. Although the Connection Time sensor is unavailable. I can submit this as an issue if you'd prefer. |
Please do, thanks @mikesalz! I'm currently working on the polling interval config and the checkbox popup weirdness before I move on to other things, but I can fix that sensor next. |
I've got v0.1.1 now and everything is looking great. Thanks so much for your help with this! Please let me know if I can help test anything moving forward. |
@mikesalz you're all set with the polling config option now, v0.1.2 should show up in HACS as available for you to upgrade to. Let me know if you have any issues! Here's what it looks like at the bottom of the popup, and changing it doesn't require a restart. Default is the current 30 second interval. |
Looks great! Thanks @binarydev! I installed v0.1.2 and lowered the polling interval, but it's a little difficult to test. I'll keep an eye on it next time the generator runs its exercise routine. Thanks so much for your work here!! |
This is just a small thing I noticed after installing this integration. Just wanted to give you the heads up!
The text was updated successfully, but these errors were encountered: