Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PY34 is defined inconsistently compared to PY2 and PY3 #147

Open
benjaminp opened this issue Jan 12, 2016 · 0 comments
Open

PY34 is defined inconsistently compared to PY2 and PY3 #147

benjaminp opened this issue Jan 12, 2016 · 0 comments

Comments

@benjaminp
Copy link
Owner

Originally reported by: astrofrog (Bitbucket: astrofrog, GitHub: astrofrog)


The constant PY34 is badly named: PY2 means Python 2, PY3 means Python 3, but PY34 will be True for Python 3.6 or Python 4.3, which will read weirdly in code.

I would therefore propose renaming PY34 to PY_GE_34, and introducing a new variable PY_GE_3 to mean sys.version_info[0] >= 3.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant