Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es-module-shims should probably be removed (from the startup pattern) #11

Open
chase-moskal opened this issue Jun 23, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@chase-moskal
Copy link
Member

we used to always rely on es-module-shims to power dev mode

but now, all the browsers except ie11 supports import maps,

so i think we can stop using es-module-shims, since we can assume developers will use modern browsers.

💡 maybe it's smarter to relegate es-module-shims as an option, so we can enable it for the specific case of debugging in ie11..

@chase-moskal chase-moskal added the enhancement New feature or request label Jun 23, 2023
@chase-moskal
Copy link
Member Author

i think we should fully abandon IE11 an remove es-module-shims entirely.

if we need to debug something in IE11, we can manually add es-module-shims where it's needed for the specific purpose.

  • we'll rework the startup scripts pattern to remove es-module-shims
  • we'll remove es-module-shims from /s/scripts/turtle-install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant