Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem about the result #21

Closed
Yuan0320 opened this issue Sep 1, 2020 · 9 comments
Closed

problem about the result #21

Yuan0320 opened this issue Sep 1, 2020 · 9 comments

Comments

@Yuan0320
Copy link

Yuan0320 commented Sep 1, 2020

I used paper_defaults.jsonnet to reproduce the result of 0.40 in the paper, but with another configuration defaults.jsonnet ran for many times, the maximum reached 0.41 instead of 0.47. I am a little confused, can you help me approach the problem, thank you!

@benbogin
Copy link
Owner

benbogin commented Sep 1, 2020

Hi, training the model as described should give 47-48 for the sql_match metric, did you run it exactly as described?
Can you list the actions you have done to train, and share the final metrics file you get?

@Yuan0320
Copy link
Author

Yuan0320 commented Sep 2, 2020

metrics.json.zip
Hi! The above is the best result after I run defaults.jsonnet many times.
I did it as you described, first install and configure, and then use the AllenNLP command to train. It can run successfully and I can used paper_defaults.jsonnet to get the result 0.40 in the paper.

@Yuan0320
Copy link
Author

Yuan0320 commented Sep 3, 2020

Hi!
"train_data_path": dataset_path + "train_spider.json",
And does this mean that we only used train_spider.json in the official Spider training dataset, but not train_others.json?(there are two official Spider training dataset, train_spider.json and train_others.json)
Thanks!

@Yuan0320 Yuan0320 changed the title problem problem with result Sep 3, 2020
@Yuan0320 Yuan0320 changed the title problem with result problem about result Sep 3, 2020
@Yuan0320 Yuan0320 changed the title problem about result problem about the result Sep 3, 2020
@benbogin
Copy link
Owner

benbogin commented Sep 3, 2020

Sorry, I am unsure of why you get different results. When the repository was first out, starting from a clean environment and running the default configuration, I got 47-48 percent accuracy, and other reported the same. Perhaps there were some changes to packages since them? Are you using the same versions of packages?

One thing you could do is to try the follow-up repository - https://github.com/benbogin/spider-schema-gnn-global
It is based on the same code, with a few changes. Running it without the re-ranker should get you around 49.3 accuracy.

Regarding your last question - yes, we only trained on train_spider.json (the rest of the dataset did not improve our results, although you can re-test this if you'd like)

@Yuan0320
Copy link
Author

Yuan0320 commented Sep 4, 2020

I checked the version of the packages and it is the same as yours. How many times did you run it to achieve 0.47? I see issue #5 and its result is only 0.43.Thanks!

@benbogin
Copy link
Owner

benbogin commented Sep 5, 2020

I ran it once or twice to reproduce the results from pull request #13, and got about the same results, but since then I've worked mostly with the follow-up repository. Let me know if you have trouble reproducing the results there as well

@Yuan0320
Copy link
Author

Yuan0320 commented Sep 6, 2020

Oh,sorry! I can reproduce the 0.47 result now, which is my problem.Thanks!

@benbogin
Copy link
Owner

benbogin commented Sep 6, 2020

Glad to hear. What was the issue?

@Yuan0320
Copy link
Author

Yuan0320 commented Sep 6, 2020

So far I don't know where the problem is. I re-downloaded your project and ran it, and found that a result of 47 was successfully obtained. It's my problem, sorry!

@benbogin benbogin closed this as completed Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants