Text escaping not correct

[crazytyper]

The valid character range for XML is specified as:

Char := #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x10000-#x10FFFF]

When producing XML using WriteTo a set of strings.Replacer objects in etree.go are used to escape strings.

However, these replacers fail to replace some characters that are not valid in XML (e.g. 0xB vertical tab).

This leads to invalid XML being produced.

The go standard package xml replaces invalid characters with \uFFFD (unicode replacement character) which appears to be common practice across other XML libraries.

I propose using xml.EscapeText instead of the current approach based on strings.NewReplacer(...).

[beevik]

thanks for the feedback. I'll take a look at this.

[beevik]

This should be fixed in 69ce3ef

Thanks for the report!