Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release cleanups #109

Open
7 of 17 tasks
lowi-yeah opened this issue Sep 29, 2017 · 2 comments
Open
7 of 17 tasks

Pre-release cleanups #109

lowi-yeah opened this issue Sep 29, 2017 · 2 comments

Comments

@lowi-yeah
Copy link

lowi-yeah commented Sep 29, 2017

General

  • WORDING: change BeeTwo organisation name from @bee2 to @beetwo fixed - sean
  • CSS: Some more whitespace would be nice.
  • CSS: Active and hover links are underlined. This is weird on touch devices. Would it make sense to adjust the underline to be there ONLY on :hover?

Notifications

  • CSS: Notifications are not positioned absolutely (when dismissed, the rest of the DOM moves)
  • CSS: Notifications stick to the top without any margin.

Menu

  • CSS: Icons & labels are not aligned properly
  • JS: Mobile burger menu: Close menu after clicking a link.

Profile Page

  • CSS: There's no alignment of the righthand columns (‘change phone number’ vs. activity label vs. notification settings)
  • QUESTION: What does the ‘active’ label mean in ‘Membership’?

Needs

Add Need

  • WORDING: The placeholder description beginning with ‘Demand’ sounds rather harsh removed the placeholder for now
  • QUESTION: Maybe put a second cancel-button to the left of the ‘Add need’-button? !question

Overview

Map

  • Very nice!

Detail

  • CSS: There are a lot of styles & colors:
    • blue links (eg. organisation, username)
    • a bright blue link (username)
    • a green link that underlines on active (status change)
    • bright blue text (status)
    • grey text (‘status’, ‘organisation’, comment-time)
    • light grey text (‘marked issue as’)
    • green, yellow and red badges
    • a pale blue button (send)
    • a grey link, that turns yellow on active (attachment)

Status

  • JS: When clicking on ‘change’, a select dropdown opens and I can select something. The dropdown closes, but the status remains the same.
  • CSS: Why is the change link green?
  • CSS: Why is the ‘resolved’ blue on the detail site and grey in the dropdown?

Organisations

Detail

  • CSS: Why dare there two different hues of blue?
  • CSS: Contact link is center aligned with the icon / Location is bottom aligned with the icon

Map

  • The organisation marker is but a circle.
@mcallistersean
Copy link
Collaborator

mcallistersean commented Sep 29, 2017

When clicking on ‘change’, a select dropdown opens and I can select something. The dropdown closes, but the status remains the same.

This would be a release-blocker.
Luckily it works form me ;-)
@lowi-yeah Could you please clarify: e.g. which browser, stacktrace something ..

@fadr
Copy link
Collaborator

fadr commented Sep 29, 2017

CSS: Icons & labels are not aligned properly

They are over here, can you make a screenshot of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants