Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ! for view access #72

Open
omus opened this issue Mar 25, 2021 · 2 comments
Open

Support ! for view access #72

omus opened this issue Mar 25, 2021 · 2 comments

Comments

@omus
Copy link
Member

omus commented Mar 25, 2021

Add support for using ! while using getindex to access a view instead of a copy. For example:

samples[channel, !]

People familiar with DataFrames.jl should already be used to this.

There are probably some good reasons not to do this. If so this issue can be useful for future reference.

@omus
Copy link
Member Author

omus commented Mar 25, 2021

One reason not to do this is that you can't access a view when accessing a single element (e.g. view(sample, channel, 1)

@jrevels
Copy link
Member

jrevels commented May 15, 2024

this is borderline superseded by #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants