-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-check spatialmath #143
Comments
Initial error, along with version info:
|
Next up:
Even though I'm running python 3.10, |
After upgrading
|
Focusing on
It looks like the python version conditionals are not written in a way that |
Fixing that reveals more problems:
Note that the errors come from 2 fewer files, since it is now skipping |
Addressing
This can be addressed with |
Various imports don't have types or stubs available; |
I'd love to have more complete type hinting, but the endless changes in type hinting syntax is a big disincentive. From py3.10 things settle down pretty nicely and we have builtin generic type hints and the I've not used |
Spatialmath should be type-checked using
mypy
; it is full of type annotations, but without a type-checker confirming them, they may be inaccurate. Runningmypy
reveals various errors; resolving the first few reveal many more (>500).Generally, these should be resolved without changing the interface or implementation when possible.
The text was updated successfully, but these errors were encountered: