CONSUMED date - NameX needs to know that a NR is consumed

[Kaineatthelab]

Description: NameX needs to know that a NR is consumed (consumption date and corp_num of entity that was created) or if NWPTA Partner Search is complete.

Prior to starting on development for this task, can you please provide a dev estimate, working with Steven Chen? I will assign his as well once he is set up in ZenHub.

Please review and estimate the following:

• What parts of NameX need to change in order to accommodate this?
• Roughly how much work would changes to each part take?

The front-end aspects (where/when to display/edit) can be considered separately from this ticket.

Acceptance / DoD:

• Design / Solution accepted by Product Owner
• Test coverage acceptable
• Peer Reviewed
• UX Approved
• PR Accepted
• Production burn in completed

[stevenc987]

Description: NameX needs to know that a NR is consumed (consumption date and corp_num of entity that was created). NameX needs to know if a NWPTA Partner name search is completed (partner_name_number and partner_name_date)

Prior to starting on development for this task, can you please provide a dev estimate, working with Steven Chen? I will assign his as well once he is set up in ZenHub.

Please review and estimate the following:

• What parts of NameX need to change in order to accommodate this?
• Roughly how much work would changes to each part take?

The front-end aspects (where/when to display/edit) can be considered separately from this ticket.

Acceptance / DoD:

• Design / Solution accepted by Product Owner
• Test coverage acceptable
• Peer Reviewed
• UX Approved
• PR Accepted
• Production burn in completed

Following parts of NameX need to change in order to accommodate the requirements:

1. Add ‘CONSUME’ and ‘EXPIR’ to namex_pkb.sql. 
   

2. Add fields to \namex\nro-legacy\sql\object\names\namex\view\names_vw.sql
3. Add fields (consumption_date, corp_num) to get_names(session, request_id) in \namex\api\namex\services\nro\request_utils.py
4. Add fields (consumption_date, corp_num) to add_names(nr, nr_names) in \namex\api\namex\services\nro\request_utils.py
5. Add field (corp_num) to model \namex\api\namex\models\name.py
6. Add ‘CONSUME’ and ‘EXPIR’ type to \namex\api\tests\python\nro_services\test_update_request.py and rerun test
7. Add fields to \namex\api\tests\python\models\test_names.py and rerun test
8. Add fields to \namex\api\tests\python\nro_services\test_nro_request_utils.py and rerun test
9. Add fields to \namex\api\tests\postman\xxxx-postman_collection.json and rerun test.
10. Handle existing transaction_id in name_transaction table with CONSUME and EXPIR type to be bought to postgres table.
11. NWPTA - Pull data from namesp.partner_name_system into Namex. Partner_name_number and partner_name_date are required. When pulled data must be linked to the BC Name request. This is done in namesp using request_ID.

Estimate:

1. Database SQL change (about 1 day)
2. Codes change (about 3 days)
3. Testing (about 2 days)
4. Handle existing transaction_id in name_transaction table (about 1 day)

If the detailed implementation work is assignment to me, I will have to figure out how to debug, build, deploy, and test the project. So it would take a bit more time. Thanks.

[katiemcgoff]

NWPTA - Conclusion per Steven, confirmed by Melissa and Katie - we're already collecting NWPTA info in extractor BUT it doesn't really matter anyway because the examiners should be entering completed NWPTA info in Namex, not NRO.

[katiemcgoff]

@Kaineatthelab @LJTrent This ticket asks for expired transaction to be collected from NRO - why do we care?

[katiemcgoff]

Conclusion to above q (from slack conversations): we do not need to track EXPIR transaction for namex, so Steven to remove from queue_data_for_namex code.