Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outputs: incorporation effective date for an FED filing should not be blank #23958

Closed
1 of 2 tasks
severinbeauvais opened this issue Oct 22, 2024 · 5 comments
Closed
1 of 2 tasks
Assignees
Labels
bug Something isn't working Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. Priority2

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 22, 2024

Current State

  • For a FED IA, the temporary incorporation application has a section, "Incorporation Effective Date" and no body.
  • Here's a sample temporary incorporation application that is not FED, and it shows a body.

image.png

  • The email sent at this time contains the FE date, so the output should be able to display it as well.

Tasks

  • The text should read "The {filing type} is to take effect on {FE date and time}." Example "The continuation is to take effect on October 7, 2024 at 8:00 pm Pacific time."
    • Note: Non FED filings should continue to have the text "The {filing type} is to take effect at the time that this application is filed with the Registrar."
  • If possible, please fix the key-value alignment in the header: there are 3 keys and only 2 values but it's not clear which values are for which keys. (Maybe use   non-breaking space to take up space and force alignment.) --- Should this task be in this ticket or Ticket 24013? @severinbeauvais

Design

Figma Design: Future Effective IA Output

@severinbeauvais severinbeauvais added bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority2 labels Oct 22, 2024
@Mihai-QuickSilverDev Mihai-QuickSilverDev changed the title Outputs: incorporation effective date should not be blank Outputs: incorporation effective date for an FED filinig should not be blank Oct 24, 2024
@severinbeauvais severinbeauvais changed the title Outputs: incorporation effective date for an FED filinig should not be blank Outputs: incorporation effective date for an FED filing should not be blank Oct 24, 2024
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Oct 24, 2024

Check the templates to determine whether the property to display is effective_date_time or header.effective_date_time.

Please test the following FE filings:

  • amalgamation effective date-time
  • alteration effective date-time
  • voluntary dissolution effective date-time
  • continuation effective date-time
  • incorporation effective date-time

@davemck513 davemck513 added Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. and removed Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. labels Oct 30, 2024
@kzdev420 kzdev420 self-assigned this Nov 5, 2024
@eason-pan-bc
Copy link
Collaborator

eason-pan-bc commented Nov 7, 2024

As per discussion, this ticket will focus on Display future effective date statement.

The Ensure retrieved date value aligns with label and Display recognition date in the header work will be covered in #24013

@vishnup0422
Copy link
Collaborator

vishnup0422 commented Nov 8, 2024

IA FED Filing

image.png

Voluntary Dissolution FED

image.png

Amalgamation FED

image.png

Continuation IN

image.png

Alteration

image.png

@vishnup0422
Copy link
Collaborator

vishnup0422 commented Nov 8, 2024

removed video

@severinbeauvais
Copy link
Collaborator Author

The video above does not show the future effective date in the alteration application output prior to the time or after it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. Priority2
Projects
None yet
Development

No branches or pull requests

5 participants