Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filings UI: verify short form draft display, actions, etc #19038

Closed
severinbeauvais opened this issue Dec 15, 2023 · 3 comments
Closed

Filings UI: verify short form draft display, actions, etc #19038

severinbeauvais opened this issue Dec 15, 2023 · 3 comments
Assignees
@ketaki-deodhar
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. ENTITY Business Team UX Assurance

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Dec 15, 2023 •
edited
Loading

  • was done for regular amalgamations in Filings UI: show draft amalgamation #18534
    • verify for horiz and vert
  • add unit tests to verify these cases!
    • entity info header (title + subtitle)
    • todo item filing name
    • todo item actions
    • the things that are supposed to be disabled
@severinbeauvais severinbeauvais added the ENTITY Business Team label Dec 15, 2023
@severinbeauvais severinbeauvais added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Jan 23, 2024
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Jan 27, 2024 •
edited
Loading

Looks like it's working fine already!

https://dev.business.bcregistry.gov.bc.ca/TmH97h66fN/?accountid=3040
image.png

However, I'm sure there are some unit tests to add.

@ketaki-deodhar ketaki-deodhar self-assigned this Jan 29, 2024
@ketaki-deodhar ketaki-deodhar mentioned this issue Jan 31, 2024
Merged
@severinbeauvais
Copy link
Collaborator Author

Today is Ketaki's flex day but her PR is merged and the rest of this ticket looks complete, so I've moved this to UXA.

@yuisotozaki
Copy link

Ready for QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ketaki-deodhar ketaki-deodhar

Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. ENTITY Business Team UX Assurance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@severinbeauvais @yuisotozaki @ketaki-deodhar @OlgaPotiagalova