Create UI: implement new Amalgamating Businesses component - Part III

[Mihai-QuickSilverDev]

This ticket is the second third of this new component.

This ticket can be started (but not finished) before #18535 is finished.

To do:

• implement table - see UI designs for various scenarios
  • consider what a foreign business looks like (see 18722) re: optional data
• implement review version of table (step 5)
• implement calls to Legal API to fetch business data done in Create UI: implement new Amalgamating Businesses component - Part I - DO THIS FIRST! #18535
  • except foreign companies
  • verify affiliation (may need to handle 401, or call Auth API instead)
  • fetch mailing address
  • fetch email (contact point)
• figure out "amalgamatingBusinesses" data structure
• implement initial validations
  • per item (see constraints and other rules) -- see UI designs for various scenarios
    • if staff, show validation issues but allow NIGS and foreign (ie, show warning icon but component is valid)
    • if staff, allow un-affiliated businesses in table (since staff can fetch their data always) (no need to add to MBR)
  • for entire component
• implement tooltips - see UI designs for various scenarios
  • if there are multiple validation issues, only show the most important one
• implement "Remove" action
• implement "Adopt NOA from this business" action in sub-menu obsolete
  • prepopulate the following from this business (see a NOA for example):
    • business addresses
    • contact info
    • people and roles (including incorporator + directors) (completing party is for THIS filing)
    • share structure
    • incorporation agreement
    • override original amalgamation entity type (if numbered)
    • show validation error if doesn't match amalg entity type (if NR)
• implement remaining validations (per rules document below) moved to Create UI: Amalgamating Businesses component - Part 3b (remaining validations) #18971
• verify table is validated when a draft is resumed (ie, when this component is created/mounted) done by Karim
• verify table is validated when a new NR is used (ie, verify compatible entity types) future; cannot add NR yet
• ensure validations are up to date when user clicks File and Pay no need -- table validations are reactive

Notes:

• pure EP amalgamations are out of scope (ie, resulting company is xpro)
• regular users cannot continue with an EP (A company)
  • validation error
  • this must become a staff filing (staff could continue the existing draft)
• allow end-users to search for an A company, but show validation error (which will block the filing)
• staff can use A companies
• staff can use foreign companies (see how they were added in Create UI: implement new Amalgamating Businesses component - Part I - DO THIS FIRST! #18535)
• EP (A type) and other Foreign businesses cannot be part of a Short Form Horizontal amalgamation
• staff can complete an amalgamation even if any company is Not in Good Standing
• all businesses must be affiliated to the account, even for staff not needed for staff
• if a call must be made to Auth API, cache the affiliations response to avoid multiple network calls
• see constraints in BC Ltd Amalgamations Constraints #18545
• see constraints in CCC Amalgamations Constraints #18544
• see constraints in ULC Amalgamations Constraints #18543
• see constraints in Staff Users Constraints #18542

Consolidated rules: https://docs.google.com/document/d/1Dt2jzPA2SLtQO7Ns2aPCzVchGdv4YrYB/edit

[severinbeauvais]

@yuisotozaki Only a few validations are currently implemented so far but could you please have a look at the UI and UX now? This is now in Dev.

[severinbeauvais]

This ticket has been implemented and deployed to Dev.

Note the following incomplete items:

• advanced validations (business type mismatches, etc) - to be completed in Create UI: Amalgamating Businesses component - Part 3b (remaining validations) #18971
• re-fetching ting business info on resuming a draft - to be completed in Create UI - Re-fetch Businesses info of draft amalgamation #18960

[yuisotozaki]

@severinbeauvais Are the "initial validations" implemented in this ticket? The affiliation check appears in the description above, but also covered in the advanced validation document linked in 18971.

[severinbeauvais]

Yes, some validations are in place, but maybe don't focus on those and instead leave it for the next ticket ;)

[yuisotozaki]

Observations:

• Hover on Ready status checkbox does not trigger a tooltip.
• Cannot test foreign company in the list yet (will do when the UI is up)

[severinbeauvais]

Is a tooltip required on the Ready status check mark? Could you point me to the UI design for its text?

[yuisotozaki]

The business list component off screen to the right has tooltip on Ready status row.
https://preview.uxpin.com/7f4cfe5fe4b0ba15a83d518177efe82a08e99167#/pages/164828179

[severinbeauvais]

Thanks. Can I move this requirement to #18971 so that we can move THIS ticket along?

[yuisotozaki]

Let's do it!
Ready for QA.