Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAMEX-API - MBR Enhancement - NR SEARCH - Add APPROVED but unfurnished NR's to database query #18628

Open
seeker25 opened this issue Nov 16, 2023 · 6 comments
Assignees
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Names Team Name Request Name Examination Team

Comments

@seeker25
Copy link
Collaborator

seeker25 commented Nov 16, 2023

Currently DRAFT, INPROGRESS both show up almost instantly in the Names Search on the MBR.

INPROGRESS or DRAFT:

Private Zenhub Image

Then there's a bit of a delay when going from INPROGRESS -> APPROVED, it's 5 minutes or so and makes the NR not show up until it's furnished: (unfurnished + APPROVED screenshot below)

Private Zenhub Image

Ideally we'd like to change the database query so it includes NR's that are APPROVED and unfurnished, so they can still be added to the business dashboard (but not consumed until they are furnished) (these wont be included in the SOLR response):

Private Zenhub Image

Relevant code:
https://github.com/bcgov/namex/blob/aaaae97efdac1ede9542d6d46db24e5bf56d1092/api/namex/resources/requests.py#L423

@seeker25 seeker25 added the ENTITY Business Team label Nov 16, 2023
@seeker25 seeker25 changed the title Namex-api - MBR Enhancement - Add APPROVED but unfurnished NR's to database query NAMEX-API - MBR Enhancement - NR SEARCH - Add APPROVED but unfurnished NR's to database query Nov 16, 2023
@seeker25
Copy link
Collaborator Author

@Mihai-QuickSilverDev kind of what we discussed about here -^
@jdyck-fw

Ticket for you guys to groom and determine if it's worth doing

@jdyck-fw
Copy link
Collaborator

Might this actually best be suited to your team @ozamani9gh ?

@seeker25
Copy link
Collaborator Author

seeker25 commented Nov 16, 2023

It's Vysakh's work - technically I could do it (not sure if @JohnamLane would approve though), I know Vysakh is away until December

@OlgaPotiagalova OlgaPotiagalova added Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. and removed ENTITY Business Team labels Jan 3, 2025
@ozamani9gh ozamani9gh added the Names Team Name Request Name Examination Team label Feb 6, 2025
@severinbeauvais
Copy link
Collaborator

@seeker25 As NRO is now decommissioned, the 5 minute delay no longer exists. Is this bug still valid? Thanks.

@seeker25
Copy link
Collaborator Author

Not sure, you'd have to try it

@severinbeauvais
Copy link
Collaborator

@ozamani9gh @riyazuddinsyed , is there someone here who can verify this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Names Team Name Request Name Examination Team
Projects
None yet
Development

No branches or pull requests

5 participants