Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE - Allow Limited Companies and others to affiliate ahead of any releases - Plan feasibility #18472

Closed
JohnamLane opened this issue Nov 3, 2023 · 11 comments
Labels
Epic Pay Work for Pay Team

Comments

@JohnamLane
Copy link
Collaborator

Since BC Ltd. and related corporation types are our highest-volume business type, efforts are being made to spread out the onboarding pain experienced during the go-live.

This specific epic is looking at allowing businesses to affiliate prior to being officially 'live' in Lear. Our task is to perform a research spike into this idea and to log and estimate effort needed to do this. If it is not feasible or very complicated to implement then we can advise that as well.

@seeker25
Copy link
Collaborator

seeker25 commented Jan 2, 2024

I've tried business search in PROD, it can see BC Limited Companies (Legal type BC)

Steps required:

  1. Feature flag to enable BC companies for business search in the business dashboard
  2. Feature flag to enable passcodes for BC corps etc
  3. Make sure the entities are loaded in the auth-db.entities table from LEAR. Usually the entity-filer does this when it's created, I think in this scenario we'll have to do it. Consult with Argus on this one, I'm sure he did it for firms.
  4. Update the contacts inside of AUTH, so the user has multiple affiliation options.

After these steps, clients should be able to associate businesses to their business dashboard (self-serve)

@seeker25
Copy link
Collaborator

seeker25 commented Jan 4, 2024

@pstemkens What's the plan for passcodes for corps? Are there existing passcodes?

@pstemkens
Copy link
Collaborator

Yes there are currently passwords for Corps. I do not know what they are planning for the migration. I'll check with entities.

@seeker25
Copy link
Collaborator

seeker25 commented Jan 4, 2024

Ok, talking with Argus, some were self serve, others were done by providing a business identifier and org id.

So we'll need that data, if we want most of the BC companies auto affiliated. Not sure if Mihai wants to do this though, or if he'd like it to be self serve.

https://github.com/bcgov/lear/blob/673630803d56c58eccb44b4719b90d065399f715/data-tool/flows/sp_gp_affiliation_flow.py#L85-L119

[12:16 PM] Chiu, Argus CITZ:EX
they had forms and mihai consolidated everythign into excel sheet
[12:16 PM] Chiu, Argus CITZ:EX
and i just fed it into the pipeline

@seeker25
Copy link
Collaborator

seeker25 commented Jan 4, 2024

The problem is if the business doesn't have a contact email and no passcode

They'll see this message:

image

If they have a contact email or existing affiliation:

image

If they have a passcode or existing:

image

@pstemkens
Copy link
Collaborator

pstemkens commented Jan 4, 2024

Corp passwords are saved in the CORPORATION table under the CORP_PASSWORD Column. When you incorporate, adding in a password is a mandatory field.

@seeker25
Copy link
Collaborator

seeker25 commented Jan 4, 2024

But we should probably do a sanity check.. does the corp have a contact? does the corp have a passcode? Otherwise it's going to be alot of support calls

Ahh perfect, it's a requirement!

@pstemkens
Copy link
Collaborator

Most have Admin email

@seeker25
Copy link
Collaborator

seeker25 commented Jan 4, 2024

sounds good, we can just grab the passcode, pass it over to auth, insert into entities table
Also update the contacts table with the admin email if possible

ideally should have both admin email and passcode

@seeker25
Copy link
Collaborator

seeker25 commented Jan 4, 2024

@Mihai-QuickSilverDev Are corps going to be entirely self serve?

image

@seeker25
Copy link
Collaborator

seeker25 commented Jan 4, 2024

Argus has found a few rows in prod with no CORP_PASSWORD and no ADMIN_EMAIL (null). 199 apparently
image.png

I think this should be manageable by staff.

There are 1719 corps that have an ADMIN_EMAIL but no passcode - I don't think this will cause performance issues, but not sure what will happen if everyone uses the magic link via email option (500k+ corps).

As discussed with Patty, might be worth staggering them over a week etc. That way the BU doesn't get swarmed with calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Pay Work for Pay Team
Projects
None yet
Development

No branches or pull requests

3 participants