Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to merge missing updates in main into legal name branch #18452

Closed
argush3 opened this issue Nov 3, 2023 · 2 comments
Closed
Assignees
Labels
ENTITY Business Team

Comments

@argush3
Copy link
Collaborator

argush3 commented Nov 3, 2023

Identify the approach and create tickets as necessary to complete this work.

Determine if is feasible to merge or cherrypick code from main into legal name branch.

Potentially this won't be possible. We may need to manually migrate most of the new changes in main.

Exclude amalgamations work in main for now.

@argush3 argush3 added the ENTITY Business Team label Nov 3, 2023
@jdyck-fw jdyck-fw changed the title Cherry pick or merge missing update in main into legal name branch Spike: Investigate how to merge missing updates in main into legal name branch Dec 13, 2023
@jdyck-fw jdyck-fw added monitor and removed monitor labels Dec 20, 2023
@argush3 argush3 changed the title Spike: Investigate how to merge missing updates in main into legal name branch Investigate how to merge missing updates in main into legal name branch Jan 15, 2024
@vysakh-menon-aot
Copy link
Collaborator

Manually merged changes until bcgov/lear@57965b4

Suggestion: Merge from 'main' into 'feature-legal-name' every 2 weeks (beginning of each sprint)

Pending work from this merge:

  • workflow
    • (new) Entity Digital Credentials CI
    • (new) Entity Digital Credentials CD
  • colin-api
    • legal-api dependency for from legal_api.services import flags. remove dependency by copying flags service to colin-api?
  • schema
    • update schema with latest changes
  • legal-api
    • added config
      • TRACTION_API
      • BUSINESS_SCHEMA
    • update EntityRole.RoleTypes to new enum variables
    • unit test fixes
  • migrate entity_digital_credentials to GCP
  • sync model to python/business_model

@argush3
Copy link
Collaborator Author

argush3 commented Jan 22, 2024

As per conversation with Vysakh, the pending working from Vysakh's working will be addressed as follows:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

4 participants