-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit Notes | Notice of Caution | Expired #18071
Comments
@LizGovier can you add the link to the design? |
@mstanton1 Design has been added |
Thanks @LizGovier |
@LizGovier Based on the ticket description, expired tickets should be removed from output. Could you please do further explanation regarding the output? I don't really know what do you mean by 'from output'. Thank you |
@LizGovier I believe the comment "Remove note from outputs" means that if the unit note is included in a search output and has expired it should not display? If so, this is the current way the system functions so we could create an API ticket and verify with Doug after - but there would be no work here for the UI. @RuoxuanPengBC let's let Liz confirm tomorrow to be safe though:) |
Hey @RuoxuanPengBC Yes, @mstanton1 is correct. Currently there is an issue with Notice of Caution, Extension to Notice of Caution, and Continued Notice of Caution when they expire. They're still showing in the MHR Table as -4 Expiry and in the search output. Unit Notes for Notice of Caution are a little tricky. If you have time tomorrow (Friday) I can walk you through the issue we're having. It could be an API issue, but think Doug set rules that if the expiry date is -# it would not show in the search output. But I'm not certain. Anyway, I think this needs a quick chat. @RuoxuanPengBC Let me know when you're available. |
@RuoxuanPengBC @LizGovier I've struck out bullet point three in the ticket description (Notes should be removed from outputs) and created Zenhub #18746 for this API work. @LizGovier can you please add design comps into that ticket and then we can groom when Doug is back? |
@mstanton1 @LizGovier Thanks for your help and clarification!! |
Hey @mstanton1, UI design has been added to 18746 |
@LizGovier @tlebedovich Temporary Url for review: https://bcregistry-assets-dev--pr-1634-l5cihor8.web.app |
@RuoxuanPengBC The expiry date in the MHR Table looks good. @mstanton1 I'm re-thinking the level of work regarding the original notice of caution(CAU) still showing after the extended caution(CAUE) has expired. In reality, this situation wouldn't occur. A Continued or Extended notice of caution would not have an expiry date that is before the original expiry date. The only reason we didn't build these rules into the date picker for CAUC or CAUE was due to the the amount of DEV work needed and because this would be a staff filing. I'm wondering if we just leave this as is because Staff should be inputting the correct dates so this error wouldn't occur. |
@LizGovier I appreciate your thoughtfulness with the depth of work completed. I agree that we can trust staff to enter valid dates. I also checked metrics and we have on average 7 cautions a year (last two years) and the number of continuations and extensions was low (4 continuations and extensions last year, 1 continuation and 0 extensions the previous year). Let's leave this out:) |
@RuoxuanPengBC This is RFQA! |
Hi @LizGovier, since we have merge-freeze Tuesday to Thursday, I cannot merge my pull request for this ticket to Dev Env by now (without merge, Divya cannot test it in Dev Env). Should I keep the ticket in UXA or move it to RFQA? |
Hey @RuoxuanPengBC Let's move this to RFQA and let @chdivyareddy know when you'll have it merged. |
@chdivyareddy Merge on hold, I will let you know when it could be tested |
@chdivyareddy Merged, ready for QA. Thank you |
Hey @RuoxuanPengBC , the expiry date for the Notice of Caution (Cancelled) displays as 'Expired' instead of 'N/A' in the MHR table. Please take a look.. MHR 107817 in DEV: |
@chdivyareddy Ready for QA! |
Example MHR 107822
When a Notice of Caution, Extension to Notice of Caution, or Continued Notice of Caution expires:
Notes should be removed from outputsmoved to API - Unit Notes | Notice of Caution | Expired #18746Figma File (RULES: 1i | Table Rules)
Private Zenhub Image
Private Zenhub Image
The text was updated successfully, but these errors were encountered: