Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - MHR Registration document issuance information updates #17599

Closed
mstanton1 opened this issue Sep 5, 2023 · 17 comments
Closed

UI - MHR Registration document issuance information updates #17599

mstanton1 opened this issue Sep 5, 2023 · 17 comments

Comments

@mstanton1
Copy link
Collaborator

mstanton1 commented Sep 5, 2023

  • update to 'Note' and intro text on Review and Confirm
  • update intro text on Step 1
  • Update text in yellow box to advise where decal is sent
  • Text addition for Submitting Party for this Registration component
  • pluralize decal under attention
    - Add new Modal for MHR table after manufacturer registration is complete (see design comps) Moved to Zenhub UI - MHR Manufacturer Registration modal #17783

See updated design comps: https://app.zenhub.com/workspaces/design-team-space-6144b1bb15dbac0013e68828/issues/gh/bcgov/entity/17554

@tlebedovich
Copy link

@mstanton1 - just added an on hold until Monday

@dimak1
Copy link
Collaborator

dimak1 commented Sep 12, 2023

@tlebedovich still on Hold?

@tlebedovich
Copy link

yes. reviewing it again tomorrow

@dimak1
Copy link
Collaborator

dimak1 commented Sep 14, 2023

@tlebedovich would like to work on this ticket if ready, otherwise if more time needed then we can push into the next Sprint @mstanton1.

@tlebedovich
Copy link

@dimak1 - did not have time in requirements meeting to review with staff. sorry. not sure if we have to wait again until next Wednesday requirement meeting to review with staff @mstanton1 ?

@mstanton1
Copy link
Collaborator Author

I think we are safe to go ahead with this one for dev purposes. Maybe instead of presenting for feedback we present it as, here's the work that was done taking into account all of the feedback.

Sharon is off now until Tuesday and we've already set up one extra meeting with her on Tuesday to review a few items so could either try to extend that and show her Tuesday (could extend to cover between 9:45-10) or we could wait until Wednesday.

@mstanton1 mstanton1 removed the On Hold label Sep 15, 2023
@dimak1
Copy link
Collaborator

dimak1 commented Sep 15, 2023

thanks @mstanton1

@dimak1 dimak1 self-assigned this Sep 15, 2023
@RuoxuanPengBC RuoxuanPengBC self-assigned this Sep 15, 2023
@dimak1 dimak1 removed their assignment Sep 15, 2023
@dimak1
Copy link
Collaborator

dimak1 commented Sep 15, 2023

@RuoxuanPengBC as discussed, this would be a good ticket for you to work on next. Let's connect later in the day to see how things are going.

@tlebedovich
Copy link

@dimak1 @mstanton1 - I updated the AC above to reflect the updates we want to move forward with and updated the design ticket with new link.

@dimak1
Copy link
Collaborator

dimak1 commented Sep 18, 2023

@tlebedovich @mstanton1 The added requirement (new modal) should've been a separate ticket. I looked at the design and have more questions about it. It's a new, more advanced modal with additional functionality, which would require its own QA cycle.
I suggest moving it out and adding it to the next Sprint.

@mstanton1
Copy link
Collaborator Author

@dimak1 I will create a new ticket for that and strike it out in this one.

@RuoxuanPengBC
Copy link

Temporary Url for review: https://bcregistry-assets-dev--pr-1538-9mkkqdaj.web.app

@RuoxuanPengBC
Copy link

@tlebedovich @LizGovier Ready for review. Thanks

@tlebedovich
Copy link

tlebedovich commented Sep 20, 2023

@RuoxuanPengBC - do you have a subaccount under BCREG0018 that is a manufacturer where I can test this? I tried the manufacturers I created but the registration button doesn't work to be able to get into their registration -

Private Zenhub Image

@RuoxuanPengBC
Copy link

@tlebedovich I don't have a subaccount under BCGRE0018. I used BCGRE0051 for development. Do you know anything about this? @dimak1

@tlebedovich
Copy link

@RuoxuanPengBC - thanks, i was able to review using BCREG0051 and it looks great. this ticket can move along!

@chdivyareddy
Copy link
Collaborator

Verified in DEV!

Private Zenhub Image

Review & Confirm:
Private Zenhub Image

Submitting Party & Attention info:
Private Zenhub Image

@PCC199 PCC199 closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants