Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sbc-common-components to Vue3 #16151

Closed
4 tasks done
seeker25 opened this issue Apr 28, 2023 · 6 comments
Closed
4 tasks done

Upgrade sbc-common-components to Vue3 #16151

seeker25 opened this issue Apr 28, 2023 · 6 comments
Assignees
Labels
Dev Tasks for developers Epic Pay Work for Pay Team techdebt

Comments

@seeker25
Copy link
Collaborator

seeker25 commented Apr 28, 2023

Reuse code from:

https://github.com/bcgov/registries-search/tree/main/search-ui/src/sbc-common-components/components

Put it into:

https://github.com/bcgov/sbc-common-components/tree/master/vue/sbc-common-components/src/components

There might be some functionality missing.

  • Phase 1 - Get existing Vue components working.
  • Phase 2 - Upgrade to Vue3/Vuetify3.
  • Phase 3 - Write unit tests for the components.
  • Phase 4 - Make sure components work in existing repos.
@seeker25 seeker25 added Dev Tasks for developers Pay Work for Pay Team labels Apr 28, 2023
@seeker25
Copy link
Collaborator Author

seeker25 commented Jun 13, 2023

Upping the estimate for this one for Tay (he was starting at ground zero for this ticket)

@seeker25
Copy link
Collaborator Author

Should be on 4.0.0-vue3

@severinbeauvais
Copy link
Collaborator

This just in, in case anyone is still using Vuex:
ktsn/vuex-class#67 (comment)

cc: @seeker25 @kialj876 @thorwolpert @cameron-eyds @ozamani9gh @pwei1018

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jul 31, 2023

I think some UIs are still importing vuex, vuex-class and vuex-module-decorators because they use sbc-common-components and it was still using Vuex.

What's the path forward? Are these imports now obsolete? How do we let all UI owners know they can update sbc-common-components and remove the vuex imports?

@seeker25
Copy link
Collaborator Author

seeker25 commented Jul 31, 2023

Still WIP, removing Vuex as we speak - I've upgraded sbc-common-components to use Vite and Vitest (Jest wasn't working in the pipeline, even though it worked on Ody's computer, Tay's computer, my computer (windows and WSL))

bcgov/sbc-common-components#330

This will make it easy to transition the components into bcrs-shared-components (end goal I'm thinking, so we don't have two component libraries to take care of - Kial also explicitly said he doesn't want to use sbc-common-components in business search)

I don't want to overload you with code reviews (code review for sbc-common-components, then another code review when we move the components over to bcrs-shared-components), so I think we should save them for when we merge over the components from sbc-common-components to bcrs-shared-components

@severinbeauvais
Copy link
Collaborator

Not the right ticket, but fwiw, Namerequest UI still uses Vuex (and sbc-c-c).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Tasks for developers Epic Pay Work for Pay Team techdebt
Projects
None yet
Development

No branches or pull requests

4 participants