-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade sbc-common-components to Vue3 #16151
Comments
Upping the estimate for this one for Tay (he was starting at ground zero for this ticket) |
Should be on |
This just in, in case anyone is still using Vuex: cc: @seeker25 @kialj876 @thorwolpert @cameron-eyds @ozamani9gh @pwei1018 |
I think some UIs are still importing What's the path forward? Are these imports now obsolete? How do we let all UI owners know they can update sbc-common-components and remove the vuex imports? |
Still WIP, removing Vuex as we speak - I've upgraded sbc-common-components to use Vite and Vitest (Jest wasn't working in the pipeline, even though it worked on Ody's computer, Tay's computer, my computer (windows and WSL)) bcgov/sbc-common-components#330 This will make it easy to transition the components into I don't want to overload you with code reviews (code review for |
Not the right ticket, but fwiw, Namerequest UI still uses Vuex (and sbc-c-c). |
Reuse code from:
https://github.com/bcgov/registries-search/tree/main/search-ui/src/sbc-common-components/components
Put it into:
https://github.com/bcgov/sbc-common-components/tree/master/vue/sbc-common-components/src/components
There might be some functionality missing.
The text was updated successfully, but these errors were encountered: